New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change strman.format parameter format #83

Open

ctaleck opened this issue Jul 3, 2018 · 1 comment

ctaleck commented Jul 3, 2018

When I use strman.format, I have to wrap the parameters in an Array as stated, but the documentation shows differently:

const select = `SELECT * FROM CONTACTS WHERE NAME LIKE '%{0}%' AND EMAIL LIKE '%{1}%'`
format(select, 'DANIEL', 'GMAIL')
// => `SELECT * FROM CONTACTS WHERE NAME LIKE '%DANIEL%' AND EMAIL LIKE '%GMAIL%'`

In my tests, I have to use:

format(select, ['DANIEL', 'GMAIL'])

I prefer the documented format (without an Array). Is it possible to also support?

The text was updated successfully, but these errors were encountered:

Author

ctaleck commented Jul 3, 2018

Solution using the spread operator on params:

var format = (value, ...params) =>
  replace(value, '{(\\w+)}',
    (match, index) => {
      if (typeof params[index] !== 'undefined') {
        return params[index]
      }
      return match
    },
  )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment