Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace deprecated ComponentFactory from Angular 13 #144

Merged
merged 22 commits into from
Sep 20, 2022

Conversation

boeckMt
Copy link
Member

@boeckMt boeckMt commented Sep 20, 2022

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

Since Angular 13 ComponentFactory.create() is deprecated and should be replaced by other APIs.

What is the new behavior?

Replaced ComponentFactory with ViewContainerRef or createComponent see: angular/angular#44926

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Is it part of one/more packages and which?

  • @dlr-eoc/map-ol
  • @dlr-eoc/core-ui

boeckMt added 22 commits August 30, 2022 09:33
Copy link
Contributor

@lucas-angermann lucas-angermann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@boeckMt boeckMt merged commit d32859e into main Sep 20, 2022
@boeckMt boeckMt deleted the fix-dynamic-component branch September 20, 2022 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants