Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug Fix] Fix undefined var bug in LegacyTUDataset #2543

Merged
merged 5 commits into from
Jan 19, 2021

Conversation

lygztq
Copy link
Contributor

@lygztq lygztq commented Jan 18, 2021

Description

  • Fix undefined var bug in LegacyTUDataset. The hidden_size is undefined when we use constant node features.
  • Fix cache file name bug in TUDataset.

Checklist

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [$CATEGORY] (such as [NN], [Model], [Doc], [Feature]])
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage
  • Code is well-documented
  • To the my best knowledge, examples are either not affected by this change,
    or have been fixed to be compatible with this change
  • Related issue is referred in this PR
  • If the PR is for a new model/paper, I've updated the example index here.

@hetong007

python/dgl/data/tu.py Outdated Show resolved Hide resolved
Copy link
Member

@hetong007 hetong007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hetong007 hetong007 merged commit 9a9a06e into dmlc:master Jan 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants