Skip to content

Enforce strides to be not null when ndim is nonzero #178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tqchen merged 4 commits into from
Oct 11, 2025
Merged

Enforce strides to be not null when ndim is nonzero #178

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
007cef0
Enforce strides to be not null when ndim is nonzero
tqchen Oct 9, 2025
ec99b37
Add more comments on the null rationale
tqchen Oct 9, 2025
63a9a32
Remove mention of framework handling
tqchen Oct 9, 2025
aa2c2cf
Update NULL note, bump minor
tqchen Oct 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 16 additions & 4 deletions include/dlpack/dlpack.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
#define DLPACK_MAJOR_VERSION 1

/*! \brief The current minor version of dlpack */
#define DLPACK_MINOR_VERSION 1
#define DLPACK_MINOR_VERSION 2

/*! \brief DLPACK_DLL prefix for windows */
#ifdef _WIN32
Expand Down Expand Up @@ -254,11 +254,23 @@ typedef struct {
int32_t ndim;
/*! \brief The data type of the pointer*/
DLDataType dtype;
/*! \brief The shape of the tensor */
/*!
* \brief The shape of the tensor
*
* When ndim == 0, shape can be set to NULL.
*/
int64_t* shape;
/*!
* \brief strides of the tensor (in number of elements, not bytes)
* can be NULL, indicating tensor is compact and row-majored.
* \brief strides of the tensor (in number of elements, not bytes),
* can not be NULL if ndim != 0, must points to
* an array of ndim elements that specifies the strides,
* so consumer can always rely on strides[dim] being valid for 0 <= dim < ndim.
*
* When ndim == 0, strides can be set to NULL.
*
* \note Before DLPack v1.2, strides can be NULL to indicate contiguous data.
* This is not allowed in DLPack v1.2 and later. The rationale
* is to simplify the consumer handling.
*/
int64_t* strides;
/*! \brief The offset in bytes to the beginning pointer to data */
Expand Down