[Refactor] 모임 일정 시간 페이징 처리 및 베스트 타임 API #126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RTUnu12
reviewed
Oct 1, 2024
Comment on lines
+12
to
+16
| @Getter | ||
| public class PagedResponse<T> { | ||
|
|
||
| private final T data; | ||
| private final PageInfo pageInfo; |
There was a problem hiding this comment.
굳이 PageInfo를 객체로 놔두는 이유를 알 수 있을까요?
There was a problem hiding this comment.
클라이언트 측 응답 JSON 형태가 data를 담는 부분 / page 정보를 담는 부분 두가지 영역으로 나뉘었으면 좋겠어서 이렇게 구분을 하는게 낫지 않을까? 라고 생각을 했어요!
There was a problem hiding this comment.
아하 알겠습니다. 유지보수가 더 쉬워질 듯 하네요.
RTUnu12
reviewed
Oct 1, 2024
Comment on lines
+142
to
+143
| .where(meeting.meetingUuid.eq(uuid) | ||
| .and(schedule.assignedAt.loe(requestTime))) |
RTUnu12
reviewed
Oct 1, 2024
| @PathVariable("meetingUuid") String uuid, | ||
| @RequestParam(value = "sort", defaultValue = "COUNT") MeetingSort sort) { | ||
| @PageableDefault(sort = "count") Pageable pageable, | ||
| @RequestParam(value = "request_time", required = false) String requestTime) { |
There was a problem hiding this comment.
이 부분은 프론트에서 API 최초 요청 시간을 보내는 건가요?
There was a problem hiding this comment.
엇 네 맞습니다.
시나리오를 생각해보면,
- 프론트에서 첫 페이지 요청을 함. (request_time은 빼고)
- 서버에서 응답시, 응답 필드에
requestTime을 추가하여 프론트가 요청한 시간을 보내줌 - 이후 프론트에서 다음 페이지 요청시, request_time 정보를 함께 서버로 요청함
- 서버에서는 요청 시간을 기준으로 이전에 저장된 일정 데이터만을 조회함. (
일정 할당 시간 <= 요청 시간)
There was a problem hiding this comment.
그러면 API의 최초 요청 시간은 파라미터에 request_time를 빼고 전송할 때 갱신되는건가요?
There was a problem hiding this comment.
네 맞아요! 그 부분을 조금 주의해서 요청을 해야해요
|
리뷰 확인 부탁드립니다. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#️⃣ 연관된 이슈
resolves #121, resolves #123
📝 작업 내용
💬 리뷰 요구사항