forked from KhronosGroup/SPIRV-Tools
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
spirv-fuzz: Fuzzer pass to randomly apply loop preheaders (KhronosGro…
…up#3668) This PR introduces FuzzerPassAddLoopPreheaders, which: - Finds existing loop headers - If they have no simple preheader (where simple means that the preheader itself is not a loop header), randomly decides whether to add one. Fixes KhronosGroup#3621.
- Loading branch information
1 parent
72ea7be
commit eade36d
Showing
6 changed files
with
122 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,66 @@ | ||
// Copyright (c) 2020 Google LLC | ||
// | ||
// Licensed under the Apache License, Version 2.0 (the "License"); | ||
// you may not use this file except in compliance with the License. | ||
// You may obtain a copy of the License at | ||
// | ||
// http://www.apache.org/licenses/LICENSE-2.0 | ||
// | ||
// Unless required by applicable law or agreed to in writing, software | ||
// distributed under the License is distributed on an "AS IS" BASIS, | ||
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
// See the License for the specific language governing permissions and | ||
// limitations under the License. | ||
|
||
#include "source/fuzz/fuzzer_pass_add_loop_preheaders.h" | ||
|
||
#include "source/fuzz/fuzzer_util.h" | ||
#include "source/fuzz/transformation_add_loop_preheader.h" | ||
|
||
namespace spvtools { | ||
namespace fuzz { | ||
|
||
FuzzerPassAddLoopPreheaders::FuzzerPassAddLoopPreheaders( | ||
opt::IRContext* ir_context, TransformationContext* transformation_context, | ||
FuzzerContext* fuzzer_context, | ||
protobufs::TransformationSequence* transformations) | ||
: FuzzerPass(ir_context, transformation_context, fuzzer_context, | ||
transformations) {} | ||
|
||
FuzzerPassAddLoopPreheaders::~FuzzerPassAddLoopPreheaders() = default; | ||
|
||
void FuzzerPassAddLoopPreheaders::Apply() { | ||
for (auto& function : *GetIRContext()->module()) { | ||
// Keep track of all the loop headers we want to add a preheader to. | ||
std::vector<uint32_t> loop_header_ids_to_consider; | ||
for (auto& block : function) { | ||
// We only care about loop headers. | ||
if (!block.IsLoopHeader()) { | ||
continue; | ||
} | ||
|
||
// Randomly decide whether to consider this header. | ||
if (!GetFuzzerContext()->ChoosePercentage( | ||
GetFuzzerContext()->GetChanceOfAddingLoopPreheader())) { | ||
continue; | ||
} | ||
|
||
// We exclude loop headers with just one predecessor (the back-edge block) | ||
// because they are unreachable. | ||
if (GetIRContext()->cfg()->preds(block.id()).size() < 2) { | ||
continue; | ||
} | ||
|
||
loop_header_ids_to_consider.push_back(block.id()); | ||
} | ||
|
||
for (uint32_t header_id : loop_header_ids_to_consider) { | ||
// If not already present, add a preheader which is not also a loop | ||
// header. | ||
GetOrCreateSimpleLoopPreheader(header_id); | ||
} | ||
} | ||
} | ||
|
||
} // namespace fuzz | ||
} // namespace spvtools |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,43 @@ | ||
// Copyright (c) 2020 Google LLC | ||
// | ||
// Licensed under the Apache License, Version 2.0 (the "License"); | ||
// you may not use this file except in compliance with the License. | ||
// You may obtain a copy of the License at | ||
// | ||
// http://www.apache.org/licenses/LICENSE-2.0 | ||
// | ||
// Unless required by applicable law or agreed to in writing, software | ||
// distributed under the License is distributed on an "AS IS" BASIS, | ||
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
// See the License for the specific language governing permissions and | ||
// limitations under the License. | ||
|
||
#ifndef SOURCE_FUZZ_FUZZER_PASS_ADD_LOOP_PREHEADERS_H | ||
#define SOURCE_FUZZ_FUZZER_PASS_ADD_LOOP_PREHEADERS_H | ||
|
||
#include "source/fuzz/fuzzer_pass.h" | ||
|
||
namespace spvtools { | ||
namespace fuzz { | ||
|
||
// A fuzzer pass that randomly adds simple loop preheaders to loops that do not | ||
// have one. A simple loop preheader is a block that: | ||
// - is the only out-of-loop predecessor of the header | ||
// - branches unconditionally to the header | ||
// - is not a loop header itself | ||
class FuzzerPassAddLoopPreheaders : public FuzzerPass { | ||
public: | ||
FuzzerPassAddLoopPreheaders( | ||
opt::IRContext* ir_context, TransformationContext* transformation_context, | ||
FuzzerContext* fuzzer_context, | ||
protobufs::TransformationSequence* transformations); | ||
|
||
~FuzzerPassAddLoopPreheaders(); | ||
|
||
void Apply() override; | ||
}; | ||
|
||
} // namespace fuzz | ||
} // namespace spvtools | ||
|
||
#endif // SOURCE_FUZZ_FUZZER_PASS_ADD_LOOP_PREHEADERS_H |