Fix(docat): Trailing Slash resulting in 404 status code #269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a slash is trailing on api functions with parameters, the api responds with 404. To fix this, I used the simple way and added a route with a trailing slash to all methods that break without it. fixes #100
|
@reglim does this fix this issue here as well? docat-org/docatl#8 |
|
@fliiiix No, the issue https://github.com/docat-org/docatl/issues/ gives you a URL like: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a slash is trailing on api functions with parameters, the api responds with 404. To fix this, I used the simple way and added a route with a trailing slash to all methods that break without it.
fixes #100