Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Built zip file not compressed #6

Closed
RSchwoerer opened this issue Jun 13, 2022 · 4 comments · Fixed by #7
Closed

Built zip file not compressed #6

RSchwoerer opened this issue Jun 13, 2022 · 4 comments · Fixed by #7

Comments

@RSchwoerer
Copy link

The zip file created with the build command is not getting compressed.
Manually zipping the file (with 7zip) gives a file around 4.5mb, using docatl build gives a file over 57mb.

Is it possible to have the build command compress the file?

@fliiiix
Copy link
Member

fliiiix commented Jun 13, 2022 via email

@RSchwoerer
Copy link
Author

I looked briefly at the archiver library being used, it does look like there simply needs to be a parameter.

Unfortunately I’m not a Go developer and probably don’t have much time to get an environment all set up to be able to build this. Otherwise I’d be happy to just submit a PR.

@RSchwoerer RSchwoerer reopened this Jun 17, 2022
fliiiix added a commit that referenced this issue Aug 26, 2022
@RSchwoerer
Copy link
Author

👏 nice! I will try to get our server updated and try it out.

@fliiiix
Copy link
Member

fliiiix commented Aug 26, 2022

in my testing the docatl zip was still a bit bigger but i guess that should be good enough now

7.1M	6.3.3.zip # created with zip
7.2M	6.3.3.zip # created with docatl

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants