Skip to content
This repository has been archived by the owner on Aug 20, 2021. It is now read-only.

remove redundant code from templates #59

Merged
merged 1 commit into from
Jan 21, 2019

Conversation

haroonKhan-10p
Copy link
Contributor

@haroonKhan-10p haroonKhan-10p commented Jan 21, 2019

Description

This PR removes the redundant code from templates which generate controls, implementation. The orca CI formatter lint checks fail and ask to format the generated files using $ gofmt -s.

minhaj10p
minhaj10p previously approved these changes Jan 21, 2019
Copy link
Contributor

@minhaj10p minhaj10p left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: aitchkhan <aitchkhan@gmail.com>
@haroonKhan-10p haroonKhan-10p changed the title remove reduntand code from templates remove redundant code from templates Jan 21, 2019
Copy link
Contributor

@anweiss anweiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@anweiss anweiss merged commit 6d17962 into docker-archive:master Jan 21, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants