Add tomee Architectures based on openjdk base image Architectures #3398
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @lordofthejars @otaviojava -- does this seem sane to you? I've personally tested this on
s390x
(and successfully run at leasttomee:7-jre-1.7.4-webprofile
), and it seems liketomee
's upstream tarballs really should "just work" anywhereopenjdk
does.See https://github.com/docker-library/official-images#architectures-other-than-amd64, https://github.com/docker-library/official-images#multiple-architectures, and #2289 for more details about multiarch + official images. 👍
I've also got a script which generates this file now, but it depends on having the
bashbrew
tool installed locally to scrape the architectures ofopenjdk
: (run from a checkout of thetomee
repo)I'd be happy to send a PR of this script too if it's interesting, but I can also just save it to run again if it's ever needed. 😄