Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update iojs to v1.7.1 #664

Merged
merged 1 commit into from
Apr 17, 2015
Merged

Conversation

Starefossen
Copy link
Contributor

This PR updated io.js to v1.7.1

PR-URL: docker-library#664
Related: nodejs/docker-iojs#50

Signed-off-by: Hans Kristian Flaatten <hans.kristian.flaatten@turistforeningen.no>
@yosifkit
Copy link
Member

Changeset: nodejs/docker-iojs@b65507...dc31c 👍

LGTM, Build test of #664; dc5fa2c (iojs):

$ url="https://raw.githubusercontent.com/docker-library/official-images/dc5fa2ccfa58f97e4781d0961f4c2383e7d7bcae/library/iojs"
$ bashbrew build "$url"
Processing iojs:1.7.1 ...
Processing iojs:1.7 ...
Processing iojs:1 ...
Processing iojs:latest ...
Processing iojs:1.7.1-onbuild ...
Processing iojs:1.7-onbuild ...
Processing iojs:1-onbuild ...
Processing iojs:onbuild ...
Processing iojs:1.7.1-slim ...
Processing iojs:1.7-slim ...
Processing iojs:1-slim ...
Processing iojs:slim ...
$ bashbrew list "$url" --uniq | xargs test/run.sh
testing iojs:1.7.1
    'utc' [1/2]...passed
    'cve-2014--shellshock' [2/2]...passed
testing iojs:1.7.1-onbuild
    'utc' [1/2]...passed
    'cve-2014--shellshock' [2/2]...passed
testing iojs:1.7.1-slim
    'utc' [1/2]...passed
    'cve-2014--shellshock' [2/2]...passed

@tianon
Copy link
Member

tianon commented Apr 17, 2015

LGTM

tianon added a commit that referenced this pull request Apr 17, 2015
@tianon tianon merged commit 0d53780 into docker-library:master Apr 17, 2015
@Starefossen
Copy link
Contributor Author

I am sorry if I should have known this, but I can not find any of the new 1.7 tags on the iojs image at Docker Hub https://registry.hub.docker.com/_/iojs/tags/manage/. Is there a delay of some sort, or was there something wrong with the PR?

@yosifkit
Copy link
Member

It looks like it is pullable, but somehow not listed there. With the update to the new go registry, there seems to be a disconnect right now. I talked to @dmp42 and he is looking into it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants