Skip to content

Add initial GitHub Actions CI #7937

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 5, 2020
Merged

Add initial GitHub Actions CI #7937

merged 1 commit into from
May 5, 2020

Conversation

@tianon
Copy link
Member

@tianon tianon commented May 4, 2020 •
edited
Loading

This is mostly an experiment.

#7937 (comment) 😅

@tianon tianon force-pushed the github-actions branch 3 times, most recently from f62a0ef to 0b6a482 Compare May 4, 2020 23:15
@yosifkit
Copy link
Member

yosifkit commented May 4, 2020

🍏 💚 🥗 📗 🟢 There was sooo much green! 🥇 💯 I like it a lot

Even the error case seems sane on bad/missing commit hash:

failed fetching/scraping FROM for "hylang" (tags "0.18.0-python3.8-buster, 0.18-python3.8-buster, 0-python3.8-buster, python3.8-buster, 0.18.0-buster, 0.18-buster, 0-buster, buster", arch "amd64")

failed fetching Git repo for arch "amd64" from entry [...] GitCommit: 5148df70ef281642faeb6508aa74cb14deadbeef\nDirectory: dockerfiles-generated\nFile: Dockerfile.python3.8-buster"

object not found

@tianon tianon force-pushed the github-actions branch 10 times, most recently from 03a578c to 43d8b0c Compare May 5, 2020 02:36
@tianon tianon force-pushed the github-actions branch 2 times, most recently from d788dd7 to ba697f7 Compare May 5, 2020 04:33
@tianon
Copy link
Member Author

tianon commented May 5, 2020

#7937 (comment) 😏

@tianon tianon force-pushed the github-actions branch 2 times, most recently from 12ca068 to 628ce0b Compare May 5, 2020 15:07
@tianon tianon force-pushed the github-actions branch 6 times, most recently from 872e603 to 01c1558 Compare May 5, 2020 18:11
@tianon tianon force-pushed the github-actions branch from 01c1558 to a0ee899 Compare May 5, 2020 18:20
@tianon tianon force-pushed the github-actions branch from 04eed09 to afb402d Compare May 5, 2020 18:23
@tianon
Copy link
Member Author

tianon commented May 5, 2020

04eed09 -> https://github.com/docker-library/official-images/runs/647082664?check_suite_focus=true

+ .github/workflows/naughty.sh

Incorrectly formatted 'latest' tags detected:
  hylang:buster-latest

Read https://github.com/docker-library/official-images#tags-and-aliases for more details.

@tianon tianon force-pushed the github-actions branch from afb402d to 530ed57 Compare May 5, 2020 18:36
@tianon
Copy link
Member Author

tianon commented May 5, 2020

530ed57 ->
image
🤘 ❗

@tianon tianon force-pushed the github-actions branch from 530ed57 to 39cc4e2 Compare May 5, 2020 18:38
@tianon tianon marked this pull request as ready for review May 5, 2020 18:40
@tianon
Copy link
Member Author

tianon commented May 5, 2020

This has been WAY more successful than I anticipated... This is no longer an experiment. 😅

@yosifkit yosifkit merged commit 9205000 into master May 5, 2020
@yosifkit yosifkit deleted the github-actions branch May 5, 2020 19:35
tianon added a commit to docker-library/oi-janky-groovy that referenced this pull request May 5, 2020
@tianon
Remove now-unused pr-labeler-pipeline
f793758 
This is now deprecated thanks to docker-library/official-images#7937 🎉
@tianon
Copy link
Member Author

tianon commented May 5, 2020

Ouch, we're running into actions/labeler#12 / https://github.saobby.my.eu.orgmunity/t5/GitHub-Actions/GitHub-actions-are-severely-limited-on-PRs/m-p/54669/highlight/true#M9249 (in other words, the token GitHub gives us for forks is explicitly read-only). 😞 🤬

(See #7942, #7943, #7944.)

@tianon
Copy link
Member Author

tianon commented May 5, 2020

See a40bfb3 and 088d51b for our (hopefully temporary??) workaround to this insanity. 😅

@tianon tianon mentioned this pull request May 8, 2020
Merged
@yosifkit yosifkit mentioned this pull request Aug 11, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yosifkit yosifkit yosifkit approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@tianon @yosifkit @docker-library-bot