From 55546d611e41cde189ba9e820c25cb5bf18a33f9 Mon Sep 17 00:00:00 2001 From: Joseph Ferguson Date: Fri, 11 Aug 2023 15:22:17 -0700 Subject: [PATCH] Skip upstream openjdk entrypoint The upstream entrypoint is `sh` and so loses dotted environment variables, lets prevent that from happening by just skipping it as the `tomcat` images are not reliant on its functionality. See https://github.com/docker-library/docs/pull/2338 and https://github.com/adoptium/containers/pull/392 for info about what it provides. Fixes https://github.com/docker-library/tomcat/issues/302 which is a recurrence of https://github.com/docker-library/tomcat/issues/77 --- 10.1/jdk11/temurin-jammy/Dockerfile | 4 ++++ 10.1/jdk17/temurin-jammy/Dockerfile | 4 ++++ 10.1/jre11/temurin-jammy/Dockerfile | 4 ++++ 10.1/jre17/temurin-jammy/Dockerfile | 4 ++++ 8.5/jdk11/temurin-focal/Dockerfile | 4 ++++ 8.5/jdk11/temurin-jammy/Dockerfile | 4 ++++ 8.5/jdk17/temurin-focal/Dockerfile | 4 ++++ 8.5/jdk17/temurin-jammy/Dockerfile | 4 ++++ 8.5/jdk8/temurin-focal/Dockerfile | 4 ++++ 8.5/jdk8/temurin-jammy/Dockerfile | 4 ++++ 8.5/jre11/temurin-focal/Dockerfile | 4 ++++ 8.5/jre11/temurin-jammy/Dockerfile | 4 ++++ 8.5/jre17/temurin-focal/Dockerfile | 4 ++++ 8.5/jre17/temurin-jammy/Dockerfile | 4 ++++ 8.5/jre8/temurin-focal/Dockerfile | 4 ++++ 8.5/jre8/temurin-jammy/Dockerfile | 4 ++++ 9.0/jdk11/temurin-focal/Dockerfile | 4 ++++ 9.0/jdk11/temurin-jammy/Dockerfile | 4 ++++ 9.0/jdk17/temurin-focal/Dockerfile | 4 ++++ 9.0/jdk17/temurin-jammy/Dockerfile | 4 ++++ 9.0/jdk8/temurin-focal/Dockerfile | 4 ++++ 9.0/jdk8/temurin-jammy/Dockerfile | 4 ++++ 9.0/jre11/temurin-focal/Dockerfile | 4 ++++ 9.0/jre11/temurin-jammy/Dockerfile | 4 ++++ 9.0/jre17/temurin-focal/Dockerfile | 4 ++++ 9.0/jre17/temurin-jammy/Dockerfile | 4 ++++ 9.0/jre8/temurin-focal/Dockerfile | 4 ++++ 9.0/jre8/temurin-jammy/Dockerfile | 4 ++++ Dockerfile.template | 6 ++++++ 29 files changed, 118 insertions(+) diff --git a/10.1/jdk11/temurin-jammy/Dockerfile b/10.1/jdk11/temurin-jammy/Dockerfile index 04de6e78f..8743a23bb 100644 --- a/10.1/jdk11/temurin-jammy/Dockerfile +++ b/10.1/jdk11/temurin-jammy/Dockerfile @@ -145,4 +145,8 @@ RUN set -eux; \ fi EXPOSE 8080 + +# upstream eclipse-temurin-provided entrypoint script caused https://github.com/docker-library/tomcat/issues/77 to come back as https://github.com/docker-library/tomcat/issues/302; use "/entrypoint.sh" at your own risk +ENTRYPOINT [] + CMD ["catalina.sh", "run"] diff --git a/10.1/jdk17/temurin-jammy/Dockerfile b/10.1/jdk17/temurin-jammy/Dockerfile index 1e0ef780b..d83ab6dd5 100644 --- a/10.1/jdk17/temurin-jammy/Dockerfile +++ b/10.1/jdk17/temurin-jammy/Dockerfile @@ -145,4 +145,8 @@ RUN set -eux; \ fi EXPOSE 8080 + +# upstream eclipse-temurin-provided entrypoint script caused https://github.com/docker-library/tomcat/issues/77 to come back as https://github.com/docker-library/tomcat/issues/302; use "/entrypoint.sh" at your own risk +ENTRYPOINT [] + CMD ["catalina.sh", "run"] diff --git a/10.1/jre11/temurin-jammy/Dockerfile b/10.1/jre11/temurin-jammy/Dockerfile index 9bf067800..c9ea8cd44 100644 --- a/10.1/jre11/temurin-jammy/Dockerfile +++ b/10.1/jre11/temurin-jammy/Dockerfile @@ -40,4 +40,8 @@ RUN set -eux; \ fi EXPOSE 8080 + +# upstream eclipse-temurin-provided entrypoint script caused https://github.com/docker-library/tomcat/issues/77 to come back as https://github.com/docker-library/tomcat/issues/302; use "/entrypoint.sh" at your own risk +ENTRYPOINT [] + CMD ["catalina.sh", "run"] diff --git a/10.1/jre17/temurin-jammy/Dockerfile b/10.1/jre17/temurin-jammy/Dockerfile index 42b525b14..e5768cfad 100644 --- a/10.1/jre17/temurin-jammy/Dockerfile +++ b/10.1/jre17/temurin-jammy/Dockerfile @@ -40,4 +40,8 @@ RUN set -eux; \ fi EXPOSE 8080 + +# upstream eclipse-temurin-provided entrypoint script caused https://github.com/docker-library/tomcat/issues/77 to come back as https://github.com/docker-library/tomcat/issues/302; use "/entrypoint.sh" at your own risk +ENTRYPOINT [] + CMD ["catalina.sh", "run"] diff --git a/8.5/jdk11/temurin-focal/Dockerfile b/8.5/jdk11/temurin-focal/Dockerfile index fcdbf6cea..03d05865f 100644 --- a/8.5/jdk11/temurin-focal/Dockerfile +++ b/8.5/jdk11/temurin-focal/Dockerfile @@ -146,4 +146,8 @@ RUN set -eux; \ fi EXPOSE 8080 + +# upstream eclipse-temurin-provided entrypoint script caused https://github.com/docker-library/tomcat/issues/77 to come back as https://github.com/docker-library/tomcat/issues/302; use "/entrypoint.sh" at your own risk +ENTRYPOINT [] + CMD ["catalina.sh", "run"] diff --git a/8.5/jdk11/temurin-jammy/Dockerfile b/8.5/jdk11/temurin-jammy/Dockerfile index 013ae7e76..4484e3db7 100644 --- a/8.5/jdk11/temurin-jammy/Dockerfile +++ b/8.5/jdk11/temurin-jammy/Dockerfile @@ -146,4 +146,8 @@ RUN set -eux; \ fi EXPOSE 8080 + +# upstream eclipse-temurin-provided entrypoint script caused https://github.com/docker-library/tomcat/issues/77 to come back as https://github.com/docker-library/tomcat/issues/302; use "/entrypoint.sh" at your own risk +ENTRYPOINT [] + CMD ["catalina.sh", "run"] diff --git a/8.5/jdk17/temurin-focal/Dockerfile b/8.5/jdk17/temurin-focal/Dockerfile index 342d635c0..f254239c9 100644 --- a/8.5/jdk17/temurin-focal/Dockerfile +++ b/8.5/jdk17/temurin-focal/Dockerfile @@ -146,4 +146,8 @@ RUN set -eux; \ fi EXPOSE 8080 + +# upstream eclipse-temurin-provided entrypoint script caused https://github.com/docker-library/tomcat/issues/77 to come back as https://github.com/docker-library/tomcat/issues/302; use "/entrypoint.sh" at your own risk +ENTRYPOINT [] + CMD ["catalina.sh", "run"] diff --git a/8.5/jdk17/temurin-jammy/Dockerfile b/8.5/jdk17/temurin-jammy/Dockerfile index 7a0c3434a..ef8065fd2 100644 --- a/8.5/jdk17/temurin-jammy/Dockerfile +++ b/8.5/jdk17/temurin-jammy/Dockerfile @@ -146,4 +146,8 @@ RUN set -eux; \ fi EXPOSE 8080 + +# upstream eclipse-temurin-provided entrypoint script caused https://github.com/docker-library/tomcat/issues/77 to come back as https://github.com/docker-library/tomcat/issues/302; use "/entrypoint.sh" at your own risk +ENTRYPOINT [] + CMD ["catalina.sh", "run"] diff --git a/8.5/jdk8/temurin-focal/Dockerfile b/8.5/jdk8/temurin-focal/Dockerfile index c024b5d9b..ec4c1e3fb 100644 --- a/8.5/jdk8/temurin-focal/Dockerfile +++ b/8.5/jdk8/temurin-focal/Dockerfile @@ -146,4 +146,8 @@ RUN set -eux; \ fi EXPOSE 8080 + +# upstream eclipse-temurin-provided entrypoint script caused https://github.com/docker-library/tomcat/issues/77 to come back as https://github.com/docker-library/tomcat/issues/302; use "/entrypoint.sh" at your own risk +ENTRYPOINT [] + CMD ["catalina.sh", "run"] diff --git a/8.5/jdk8/temurin-jammy/Dockerfile b/8.5/jdk8/temurin-jammy/Dockerfile index 458e3aae1..ae968a0f8 100644 --- a/8.5/jdk8/temurin-jammy/Dockerfile +++ b/8.5/jdk8/temurin-jammy/Dockerfile @@ -146,4 +146,8 @@ RUN set -eux; \ fi EXPOSE 8080 + +# upstream eclipse-temurin-provided entrypoint script caused https://github.com/docker-library/tomcat/issues/77 to come back as https://github.com/docker-library/tomcat/issues/302; use "/entrypoint.sh" at your own risk +ENTRYPOINT [] + CMD ["catalina.sh", "run"] diff --git a/8.5/jre11/temurin-focal/Dockerfile b/8.5/jre11/temurin-focal/Dockerfile index ddc45cbe4..6bb43df47 100644 --- a/8.5/jre11/temurin-focal/Dockerfile +++ b/8.5/jre11/temurin-focal/Dockerfile @@ -40,4 +40,8 @@ RUN set -eux; \ fi EXPOSE 8080 + +# upstream eclipse-temurin-provided entrypoint script caused https://github.com/docker-library/tomcat/issues/77 to come back as https://github.com/docker-library/tomcat/issues/302; use "/entrypoint.sh" at your own risk +ENTRYPOINT [] + CMD ["catalina.sh", "run"] diff --git a/8.5/jre11/temurin-jammy/Dockerfile b/8.5/jre11/temurin-jammy/Dockerfile index 21f309fa5..383cdb9d6 100644 --- a/8.5/jre11/temurin-jammy/Dockerfile +++ b/8.5/jre11/temurin-jammy/Dockerfile @@ -40,4 +40,8 @@ RUN set -eux; \ fi EXPOSE 8080 + +# upstream eclipse-temurin-provided entrypoint script caused https://github.com/docker-library/tomcat/issues/77 to come back as https://github.com/docker-library/tomcat/issues/302; use "/entrypoint.sh" at your own risk +ENTRYPOINT [] + CMD ["catalina.sh", "run"] diff --git a/8.5/jre17/temurin-focal/Dockerfile b/8.5/jre17/temurin-focal/Dockerfile index c17e8dcbb..2509bae28 100644 --- a/8.5/jre17/temurin-focal/Dockerfile +++ b/8.5/jre17/temurin-focal/Dockerfile @@ -40,4 +40,8 @@ RUN set -eux; \ fi EXPOSE 8080 + +# upstream eclipse-temurin-provided entrypoint script caused https://github.com/docker-library/tomcat/issues/77 to come back as https://github.com/docker-library/tomcat/issues/302; use "/entrypoint.sh" at your own risk +ENTRYPOINT [] + CMD ["catalina.sh", "run"] diff --git a/8.5/jre17/temurin-jammy/Dockerfile b/8.5/jre17/temurin-jammy/Dockerfile index 9e6d30d15..0e8d502ae 100644 --- a/8.5/jre17/temurin-jammy/Dockerfile +++ b/8.5/jre17/temurin-jammy/Dockerfile @@ -40,4 +40,8 @@ RUN set -eux; \ fi EXPOSE 8080 + +# upstream eclipse-temurin-provided entrypoint script caused https://github.com/docker-library/tomcat/issues/77 to come back as https://github.com/docker-library/tomcat/issues/302; use "/entrypoint.sh" at your own risk +ENTRYPOINT [] + CMD ["catalina.sh", "run"] diff --git a/8.5/jre8/temurin-focal/Dockerfile b/8.5/jre8/temurin-focal/Dockerfile index ebdd314ab..b4b3a4d42 100644 --- a/8.5/jre8/temurin-focal/Dockerfile +++ b/8.5/jre8/temurin-focal/Dockerfile @@ -40,4 +40,8 @@ RUN set -eux; \ fi EXPOSE 8080 + +# upstream eclipse-temurin-provided entrypoint script caused https://github.com/docker-library/tomcat/issues/77 to come back as https://github.com/docker-library/tomcat/issues/302; use "/entrypoint.sh" at your own risk +ENTRYPOINT [] + CMD ["catalina.sh", "run"] diff --git a/8.5/jre8/temurin-jammy/Dockerfile b/8.5/jre8/temurin-jammy/Dockerfile index b47fab82c..1b9784bdb 100644 --- a/8.5/jre8/temurin-jammy/Dockerfile +++ b/8.5/jre8/temurin-jammy/Dockerfile @@ -40,4 +40,8 @@ RUN set -eux; \ fi EXPOSE 8080 + +# upstream eclipse-temurin-provided entrypoint script caused https://github.com/docker-library/tomcat/issues/77 to come back as https://github.com/docker-library/tomcat/issues/302; use "/entrypoint.sh" at your own risk +ENTRYPOINT [] + CMD ["catalina.sh", "run"] diff --git a/9.0/jdk11/temurin-focal/Dockerfile b/9.0/jdk11/temurin-focal/Dockerfile index edfd312aa..96b96147d 100644 --- a/9.0/jdk11/temurin-focal/Dockerfile +++ b/9.0/jdk11/temurin-focal/Dockerfile @@ -146,4 +146,8 @@ RUN set -eux; \ fi EXPOSE 8080 + +# upstream eclipse-temurin-provided entrypoint script caused https://github.com/docker-library/tomcat/issues/77 to come back as https://github.com/docker-library/tomcat/issues/302; use "/entrypoint.sh" at your own risk +ENTRYPOINT [] + CMD ["catalina.sh", "run"] diff --git a/9.0/jdk11/temurin-jammy/Dockerfile b/9.0/jdk11/temurin-jammy/Dockerfile index 7d808fafc..345561104 100644 --- a/9.0/jdk11/temurin-jammy/Dockerfile +++ b/9.0/jdk11/temurin-jammy/Dockerfile @@ -146,4 +146,8 @@ RUN set -eux; \ fi EXPOSE 8080 + +# upstream eclipse-temurin-provided entrypoint script caused https://github.com/docker-library/tomcat/issues/77 to come back as https://github.com/docker-library/tomcat/issues/302; use "/entrypoint.sh" at your own risk +ENTRYPOINT [] + CMD ["catalina.sh", "run"] diff --git a/9.0/jdk17/temurin-focal/Dockerfile b/9.0/jdk17/temurin-focal/Dockerfile index d92c876e9..fb9e479ff 100644 --- a/9.0/jdk17/temurin-focal/Dockerfile +++ b/9.0/jdk17/temurin-focal/Dockerfile @@ -146,4 +146,8 @@ RUN set -eux; \ fi EXPOSE 8080 + +# upstream eclipse-temurin-provided entrypoint script caused https://github.com/docker-library/tomcat/issues/77 to come back as https://github.com/docker-library/tomcat/issues/302; use "/entrypoint.sh" at your own risk +ENTRYPOINT [] + CMD ["catalina.sh", "run"] diff --git a/9.0/jdk17/temurin-jammy/Dockerfile b/9.0/jdk17/temurin-jammy/Dockerfile index efcd7f272..3dd51c055 100644 --- a/9.0/jdk17/temurin-jammy/Dockerfile +++ b/9.0/jdk17/temurin-jammy/Dockerfile @@ -146,4 +146,8 @@ RUN set -eux; \ fi EXPOSE 8080 + +# upstream eclipse-temurin-provided entrypoint script caused https://github.com/docker-library/tomcat/issues/77 to come back as https://github.com/docker-library/tomcat/issues/302; use "/entrypoint.sh" at your own risk +ENTRYPOINT [] + CMD ["catalina.sh", "run"] diff --git a/9.0/jdk8/temurin-focal/Dockerfile b/9.0/jdk8/temurin-focal/Dockerfile index 59da05202..35a90b4a0 100644 --- a/9.0/jdk8/temurin-focal/Dockerfile +++ b/9.0/jdk8/temurin-focal/Dockerfile @@ -146,4 +146,8 @@ RUN set -eux; \ fi EXPOSE 8080 + +# upstream eclipse-temurin-provided entrypoint script caused https://github.com/docker-library/tomcat/issues/77 to come back as https://github.com/docker-library/tomcat/issues/302; use "/entrypoint.sh" at your own risk +ENTRYPOINT [] + CMD ["catalina.sh", "run"] diff --git a/9.0/jdk8/temurin-jammy/Dockerfile b/9.0/jdk8/temurin-jammy/Dockerfile index 838790354..24c34a74f 100644 --- a/9.0/jdk8/temurin-jammy/Dockerfile +++ b/9.0/jdk8/temurin-jammy/Dockerfile @@ -146,4 +146,8 @@ RUN set -eux; \ fi EXPOSE 8080 + +# upstream eclipse-temurin-provided entrypoint script caused https://github.com/docker-library/tomcat/issues/77 to come back as https://github.com/docker-library/tomcat/issues/302; use "/entrypoint.sh" at your own risk +ENTRYPOINT [] + CMD ["catalina.sh", "run"] diff --git a/9.0/jre11/temurin-focal/Dockerfile b/9.0/jre11/temurin-focal/Dockerfile index 215cf5c64..d0e9eb6c6 100644 --- a/9.0/jre11/temurin-focal/Dockerfile +++ b/9.0/jre11/temurin-focal/Dockerfile @@ -40,4 +40,8 @@ RUN set -eux; \ fi EXPOSE 8080 + +# upstream eclipse-temurin-provided entrypoint script caused https://github.com/docker-library/tomcat/issues/77 to come back as https://github.com/docker-library/tomcat/issues/302; use "/entrypoint.sh" at your own risk +ENTRYPOINT [] + CMD ["catalina.sh", "run"] diff --git a/9.0/jre11/temurin-jammy/Dockerfile b/9.0/jre11/temurin-jammy/Dockerfile index d97e737ce..a34590cb0 100644 --- a/9.0/jre11/temurin-jammy/Dockerfile +++ b/9.0/jre11/temurin-jammy/Dockerfile @@ -40,4 +40,8 @@ RUN set -eux; \ fi EXPOSE 8080 + +# upstream eclipse-temurin-provided entrypoint script caused https://github.com/docker-library/tomcat/issues/77 to come back as https://github.com/docker-library/tomcat/issues/302; use "/entrypoint.sh" at your own risk +ENTRYPOINT [] + CMD ["catalina.sh", "run"] diff --git a/9.0/jre17/temurin-focal/Dockerfile b/9.0/jre17/temurin-focal/Dockerfile index 4c9051c4f..d261f1b70 100644 --- a/9.0/jre17/temurin-focal/Dockerfile +++ b/9.0/jre17/temurin-focal/Dockerfile @@ -40,4 +40,8 @@ RUN set -eux; \ fi EXPOSE 8080 + +# upstream eclipse-temurin-provided entrypoint script caused https://github.com/docker-library/tomcat/issues/77 to come back as https://github.com/docker-library/tomcat/issues/302; use "/entrypoint.sh" at your own risk +ENTRYPOINT [] + CMD ["catalina.sh", "run"] diff --git a/9.0/jre17/temurin-jammy/Dockerfile b/9.0/jre17/temurin-jammy/Dockerfile index 4bb651bf6..6be65a66d 100644 --- a/9.0/jre17/temurin-jammy/Dockerfile +++ b/9.0/jre17/temurin-jammy/Dockerfile @@ -40,4 +40,8 @@ RUN set -eux; \ fi EXPOSE 8080 + +# upstream eclipse-temurin-provided entrypoint script caused https://github.com/docker-library/tomcat/issues/77 to come back as https://github.com/docker-library/tomcat/issues/302; use "/entrypoint.sh" at your own risk +ENTRYPOINT [] + CMD ["catalina.sh", "run"] diff --git a/9.0/jre8/temurin-focal/Dockerfile b/9.0/jre8/temurin-focal/Dockerfile index 848ab40f3..8acbcd82d 100644 --- a/9.0/jre8/temurin-focal/Dockerfile +++ b/9.0/jre8/temurin-focal/Dockerfile @@ -40,4 +40,8 @@ RUN set -eux; \ fi EXPOSE 8080 + +# upstream eclipse-temurin-provided entrypoint script caused https://github.com/docker-library/tomcat/issues/77 to come back as https://github.com/docker-library/tomcat/issues/302; use "/entrypoint.sh" at your own risk +ENTRYPOINT [] + CMD ["catalina.sh", "run"] diff --git a/9.0/jre8/temurin-jammy/Dockerfile b/9.0/jre8/temurin-jammy/Dockerfile index 4399b8d7f..15f983ed4 100644 --- a/9.0/jre8/temurin-jammy/Dockerfile +++ b/9.0/jre8/temurin-jammy/Dockerfile @@ -40,4 +40,8 @@ RUN set -eux; \ fi EXPOSE 8080 + +# upstream eclipse-temurin-provided entrypoint script caused https://github.com/docker-library/tomcat/issues/77 to come back as https://github.com/docker-library/tomcat/issues/302; use "/entrypoint.sh" at your own risk +ENTRYPOINT [] + CMD ["catalina.sh", "run"] diff --git a/Dockerfile.template b/Dockerfile.template index 4eeabc7e2..d553a0f2e 100644 --- a/Dockerfile.template +++ b/Dockerfile.template @@ -277,4 +277,10 @@ RUN set -eux; \ fi EXPOSE 8080 +{{ if vendor_variant | contains("temurin") then ( -}} + +# upstream eclipse-temurin-provided entrypoint script caused https://github.com/docker-library/tomcat/issues/77 to come back as https://github.com/docker-library/tomcat/issues/302; use "/entrypoint.sh" at your own risk +ENTRYPOINT [] + +{{ ) else "" end -}} CMD ["catalina.sh", "run"]