Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Listen for Github pull request events and build them #6

Open
3 tasks
ferrouswheel opened this issue Jan 6, 2015 · 4 comments
Open
3 tasks

Listen for Github pull request events and build them #6

ferrouswheel opened this issue Jan 6, 2015 · 4 comments

Comments

@ferrouswheel
Copy link
Contributor

Currently we only support building and testing the master branch. We should:

Requires #27

@holic
Copy link
Contributor

holic commented Jan 7, 2015

For adding commit statuses, Baleen will need its own GitHub application key that is (OAuth) authenticated with a GitHub account that has access to the repo in question. There's a special scope called repo:status specifically for status updates.

Since Baleen needs to pull down the whole repo, maybe there's a way to combine this access request with the full repo scope so that you don't have to add an SSH key for Baleen?

@ferrouswheel
Copy link
Contributor Author

It would make sense to just use a github application key rather than also require ssh deploy keys (baleen currently only uses the latter).

@holic
Copy link
Contributor

holic commented Jan 7, 2015

@heytrav
Copy link
Contributor

heytrav commented May 4, 2015

👍 It would be awesome to see if tests are passing before reviewing code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants