Issue-11374: Modified compose up command to respect COMPOSE_REMOVE_ORPHANS environment variable #11462
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ndeloof
approved these changes
Feb 5, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #11462 +/- ##
==========================================
- Coverage 58.27% 58.05% -0.23%
==========================================
Files 134 136 +2
Lines 11546 11544 -2
==========================================
- Hits 6729 6702 -27
- Misses 4153 4181 +28
+ Partials 664 661 -3 ☔ View full report in Codecov by Sentry. |
auto-merge was automatically disabled
February 6, 2024 19:28
Head branch was pushed to by a user without write access
batcity
force-pushed
the
issue-11374-bugfix
branch
from
acd6347
to
88b905e
Compare
|
Can you pleases rebase and squash your commits so we can merge ? |
batcity
force-pushed
the
issue-11374-bugfix
branch
from
8baefa0
to
abdbfb8
Compare
|
@ndeloof I've rebased and squashed my commits |
auto-merge was automatically disabled
February 17, 2024 00:33
Head branch was pushed to by a user without write access
batcity
force-pushed
the
issue-11374-bugfix
branch
7 times, most recently
from
cc32995
to
d064726
Compare
…PHANS environment variable Signed-off-by: Gautham Hullikunte <46633282+batcity@users.noreply.github.com> Signed-off-by: Gautham Hullikunte <gautham@Gauthams-MacBook-Pro.local>
batcity
force-pushed
the
issue-11374-bugfix
branch
from
d064726
to
e22dba3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did:
Modified the up command to respect the
COMPOSE_REMOVE_ORPHANSenvironment variable, It now picks up the default value for the remove orphans flag from the environment variable if theremove-orphansflag isn't provided via the CLIRelated issue:
Fixes #11374
How did I test my fix:
I created a test container using the docker compose command, then I modified the name of the service and reran the docker compose up command after including my changes
Here's the command I ran:
COMPOSE_REMOVE_ORPHANS=1 ./docker-compose upIt now respects the environment variable and deletes the orphaned containers
A picture of a cute animal, if possible in relation to what you did