This repository has been archived by the owner on Feb 1, 2021. It is now read-only.
support pulling private images from docker pull #684
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Victor Vieux <victorvieux@gmail.com>
|
ping @aluzzardi |
Closed
| @@ -251,6 +252,11 @@ func postImagesCreate(c *context, w http.ResponseWriter, r *http.Request) { | |||
| wf := NewWriteFlusher(w) | |||
|
|
|||
| if image := r.Form.Get("fromImage"); image != "" { //pull | |||
| authConfig := dockerclient.AuthConfig{} | |||
| buf, err := base64.URLEncoding.DecodeString(r.Header.Get("X-Registry-Auth")) | |||
There was a problem hiding this comment.
This looks good, however I was wondering why passing the auth only when using fromImage?
If we receive a X-Registry-Auth from the client, shouldn't we always pass it?
There was a problem hiding this comment.
when fromImage is not provided it means import, and we don't need authConfig for import
|
LGTM |
aluzzardi
added a commit
that referenced
this pull request
Apr 28, 2015
support pulling private images from docker pull
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Victor Vieux victorvieux@gmail.com