From 38e0e91d4be386e63b41b70b4a6e50f7252c4aca Mon Sep 17 00:00:00 2001 From: Michael Moravec Date: Fri, 17 Aug 2018 22:02:09 +0200 Subject: [PATCH] Deprecate Doctrine\DBAL\Types\Type::getDefaultLength() --- UPGRADE.md | 4 ++++ lib/Doctrine/DBAL/Types/Type.php | 2 +- 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/UPGRADE.md b/UPGRADE.md index e6730319b00..b16b3404176 100644 --- a/UPGRADE.md +++ b/UPGRADE.md @@ -1,5 +1,9 @@ # Upgrade to 2.9 +## Deprecated `Doctrine\DBAL\Types\Type::getDefaultLength()` + +This method was never used by DBAL internally. It is now deprecated. + ## Deprecated `NULL` value of `$offset` in LIMIT queries The `NULL` value of the `$offset` argument in `AbstractPlatform::(do)?ModifyLimitQuery()` methods is deprecated. If explicitly used in the method call, the absence of the offset should be indicated with a `0`. diff --git a/lib/Doctrine/DBAL/Types/Type.php b/lib/Doctrine/DBAL/Types/Type.php index 453631e0aaa..309db13052b 100644 --- a/lib/Doctrine/DBAL/Types/Type.php +++ b/lib/Doctrine/DBAL/Types/Type.php @@ -146,7 +146,7 @@ public function convertToPHPValue($value, AbstractPlatform $platform) * * @return int|null * - * @todo Needed? + * @deprecated Rely on information provided by the platform instead. */ public function getDefaultLength(AbstractPlatform $platform) {