Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow using on PHP 7.3 with Composer 2 #4084

Merged
merged 1 commit into from
Jun 17, 2020
Merged

Conversation

nicolas-grekas
Copy link
Member

Q A
Type bug
BC Break no
Fixed issues -

In order to support Composer 2, ocramius/package-versions requires PHP 7.4.
This effectively means that using it in "require" forces ppl on PHP 7.3 to use Composer 1.

@Seldaek created the composer/package-versions-deprecated to unlock this situation.

@greg0ire
Copy link
Member

greg0ire commented Jun 17, 2020

Why not contribute this to 2.10.x? Not sure how urgent this is, but we expect to release 3.0.0 in a little less than 2 months

@morozov
Copy link
Member

morozov commented Jun 17, 2020

Why not contribute this to 2.10.x? Not sure how urgent this is, but we expect to release 3.0.0 in a little less than 2 months

I believe 2.10.x doesn't use ocramius/package-versions.

Copy link
Member

@greg0ire greg0ire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neither does 2.11.x, this is indeed the correct branch 👍

@morozov morozov added this to the 3.0.0 milestone Jun 17, 2020
@morozov morozov merged commit e33c76a into doctrine:3.0.x Jun 17, 2020
@morozov
Copy link
Member

morozov commented Jun 17, 2020

Thanks, @nicolas-grekas!

@morozov morozov self-assigned this Jun 17, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants