Deprecate extension via Doctrine Event Manager

[morozov]

Q	A
Type	deprecation

Closes #5784.

[greg0ire]

Suggested change

	- `AbsractPlatform::$_eventManager`,
	- `AbsractPlatform::getEventManager()`,
	- `AbsractPlatform::setEventManager()`,
	- `AbstractPlatform::$_eventManager`,
	- `AbstractPlatform::getEventManager()`,
	- `AbstractPlatform::setEventManager()`,

[VincentLanglet]

Hi,

I use in my test the following code

$this->entityManager = EntityManager::create($connection, $config);

        $this->entityManager
            ->getConnection()
            ->getEventManager()
            ->addEventSubscriber(new TimestampableListener());

When i'm creating a custom entityManager, because I use doctrine-extensions:
https://github.com/doctrine-extensions/DoctrineExtensions/blob/main/src/Timestampable/TimestampableListener.php

Does this deprecation means that all the listener from doctrine-extensions will be rewritten ? Or is there another way to set them manually ?

[derrabus]

That listener does not listen on any DBAL events, so you won't have a problem.

[VincentLanglet]

That listener does not listen on any DBAL events, so you won't have a problem.

My test are failing if I remove

$this->entityManager
            ->getConnection()
            ->getEventManager()
            ->addEventSubscriber(new TimestampableListener());

thought.

And since the latest version, I get a phpstan error since getEventManager is deprecated, which was the issue I wanted to solve.

it turns out that

$eventManager = new EventManager();
$eventManager->addEventSubscriber(new TimestampableListener());

$this->entityManager = EntityManager::create($connection, $config, $eventManager);

is working, without any deprecation. So I'll do this way, but I dunno why the difference and why one way was deprecated.

[derrabus]

You retrieved the event manager from the database connection to register event listeners for the entity manager. That does not sound like a good idea, does it.

[derrabus]

$this->entityManager->getConnection()->getEventManager()

vs.

$this->entityManager->getEventManager()

[VincentLanglet]

Oh I see. Thanks