Avoid ambigous TABLE_NAME in query #6275
Conversation
|
Thank you. Can you try to add a functional test that reproduces your issue? |
|
I just found out why the error occurred. My Symfony configuration stated that MariaDB 10 is being used. The actual DB server was MySQL 8. I'll take a wild guess: MariaDB isn't that strict with ambiguous column names. Therefore, the error was not noticed from other devs with MariaDB before. MySQL 8 seems to be more strict. The question is whether this should be called a bug. The actual mistake was mine (I tricked the configuration into MariaDB even though MySQL was on the other end.). What you might want to consider is that MariaDB will also dislike ambiguous column names more in the future. |
|
Yeah, it's probably not a bug then (and cannot be tested in our CI), but I agree that making the query less ambiguous might be a good call. Can you have a look at my comment (#6275 (comment))? After that, the PR is ready to be merged, imho. |
|
Yes, your alias insertion seems good to me. Should i create new PR for the 3.8.x branch? |
No need for a new PR. Just do a rebase to solve the conflict. |
* 3.8.x: Avoid ambigous TABLE_NAME in query (doctrine#6275) Add safety check about cache value (doctrine#6283)
* 3.8.x: Avoid ambigous TABLE_NAME in query (doctrine#6275) Add safety check about cache value (doctrine#6283)
Summary
The current produced query leads to an ambigous column reference as described in the linked issue.