Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix parsing quoted table name on SQLite #6600

Merged
merged 1 commit into from
Nov 15, 2024

Conversation

morozov
Copy link
Member

@morozov morozov commented Nov 14, 2024

Q A
Type bug

The issue was discovered during the work on #6589.

The pattern used in parseTableCommentFromSQL() was invalid. It would wrap the value returned by quoteSingleIdentifier() in another set of quotes. It would only work for unquoted table names, which would be handled but the other pattern – the one that matches an unquoted name.

@morozov morozov force-pushed the sqlite-quoted-table-comment branch from 14c384f to 3cf60fc Compare November 14, 2024 20:23
@morozov morozov marked this pull request as ready for review November 14, 2024 20:24
@morozov morozov added this to the 4.2.2 milestone Nov 14, 2024
The pattern used in parseTableCommentFromSQL() was invalid. It would
wrap the value returned by quoteSingleIdentifier() in another set of
quotes. It would only work for unquoted table names, which would be
handled but the pattern that matches an unquoted name.
@morozov morozov force-pushed the sqlite-quoted-table-comment branch from 09752dc to 395269a Compare November 15, 2024 01:21
@morozov morozov changed the base branch from 4.2.x to 3.9.x November 15, 2024 01:22
@morozov morozov modified the milestones: 4.2.2, 3.9.4 Nov 15, 2024
@morozov morozov requested review from greg0ire and derrabus November 15, 2024 01:23
@morozov morozov closed this Nov 15, 2024
@morozov morozov reopened this Nov 15, 2024
@morozov morozov merged commit 34ea36f into doctrine:3.9.x Nov 15, 2024
95 of 96 checks passed
@morozov morozov deleted the sqlite-quoted-table-comment branch November 15, 2024 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants