Skip to content

Commit

Permalink
Run roave-bc-check on PRs only
Browse files Browse the repository at this point in the history
github.event.pull_request.base.sha is not defined when pushing a branch,
which means that job will always be failing for pushes.
  • Loading branch information
greg0ire committed Nov 28, 2020
1 parent dc29ed5 commit d994a7b
Show file tree
Hide file tree
Showing 2 changed files with 16 additions and 13 deletions.
16 changes: 16 additions & 0 deletions .github/workflows/bc-check.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
on:
pull_request:

jobs:
roave_bc_check:
name: "Backwards Compatibility Check"
runs-on: "ubuntu-20.04"
steps:
- uses: "actions/checkout@v2"
with:
fetch-depth: 0

- name: "Roave BC Check"
uses: "docker://nyholm/roave-bc-check-ga"
with:
args: "--from=${{ github.event.pull_request.base.sha }}"
13 changes: 0 additions & 13 deletions .github/workflows/continuous-integration.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,19 +8,6 @@ on:
- "*.x"

jobs:
roave_bc_check:
name: "Roave BC Check"
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
with:
fetch-depth: 0

- name: Roave BC Check
uses: docker://nyholm/roave-bc-check-ga
with:
args: --from=${{ github.event.pull_request.base.sha }}

phpunit:
name: "PHPUnit"
runs-on: "ubuntu-20.04"
Expand Down

0 comments on commit d994a7b

Please sign in to comment.