Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove overrides of deprecated static Command properties #1370

Merged

Conversation

derrabus
Copy link
Member

Q A
Type improvement
BC Break yes
Fixed issues Replaces #1368

Summary

Since we use the AsCommand attribute, we don't need to override $defaultName anymore. Since downstream code might rely on those properties to be present, I'm removing them on the next major.

Co-authored-by: Chris Rotter <chris.rotter@check24.de>
@derrabus derrabus added this to the 4.0.0 milestone Oct 29, 2023
@derrabus derrabus merged commit 5b3a20c into doctrine:4.0.x Oct 31, 2023
9 of 10 checks passed
@derrabus derrabus deleted the improvement/remove-static-command-props branch October 31, 2023 05:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants