Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the write-sql functionnality and add a test for it #400

Merged
merged 2 commits into from
Dec 22, 2015
Merged

Fix the write-sql functionnality and add a test for it #400

merged 2 commits into from
Dec 22, 2015

Conversation

mikeSimonson
Copy link
Contributor

No description provided.

@stof
Copy link
Member

stof commented Dec 22, 2015

Are we sure that executeRegisteredSql is called only once per migration ?

mikeSimonson added a commit that referenced this pull request Dec 22, 2015
@mikeSimonson
Merge pull request #400 from mikeSimonson/fix-write-sql
0d10df8 
Fix the write-sql functionnality and add a test for it
@mikeSimonson mikeSimonson merged commit 0d10df8 into doctrine:master Dec 22, 2015
@mikeSimonson
Copy link
Contributor Author

@stof yes unless there is a bug that I missed.

@mikeSimonson mikeSimonson added this to the 1.3.0 milestone Jan 25, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.3.0
Development

Successfully merging this pull request may close these issues.
2 participants
@mikeSimonson @stof