Refactor the getConnection into a chainloader #422
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikeSimonson
force-pushed
the
config-chainloader
branch
2 times, most recently
from
be31dd8 to
48b08bc
Compare
| { | ||
| /** | ||
| * read the input and return a Configuration, returns `false` if the config | ||
| * is not supported |
There was a problem hiding this comment.
missing documentation of the return type.
And I suggest returning Connection|null rather than Connection|false
There was a problem hiding this comment.
@stof Can you point to any documentation that would explain why the object|null is better than the object|false ?
Thanks for the review
mikeSimonson
force-pushed
the
config-chainloader
branch
from
48b08bc to
7de41d0
Compare
mikeSimonson
added a commit
that referenced
this pull request
Jan 17, 2016
Refactor the getConnection into a chainloader
|
Beautiful refactoring, this is so nice to read |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.