-
-
Notifications
You must be signed in to change notification settings - Fork 388
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for configurable migration column length. #538
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -111,6 +111,15 @@ class Configuration | |
*/ | ||
private $migrationsColumnName = 'version'; | ||
|
||
/** | ||
* The length of the string field in the migrations table. This can often be left at its default | ||
* value, but can be modified if necessary, for example, to 191 for early MySQL servers using the | ||
* UTF8MB4 character set. | ||
* | ||
* @var int | ||
*/ | ||
private $migrationsColumnLength = 255; | ||
|
||
/** | ||
* The path to a directory where new migration classes will be written | ||
* | ||
|
@@ -318,6 +327,26 @@ public function getMigrationsColumnName() | |
return $this->migrationsColumnName; | ||
} | ||
|
||
/** | ||
* Set the length of the migration string column. | ||
* | ||
* @param int $columnLength The migration string column length. | ||
*/ | ||
public function setMigrationsColumnLength($columnLength) | ||
{ | ||
$this->migrationsColumnLength = $columnLength; | ||
} | ||
|
||
/** | ||
* Returns the length of the migration string column. | ||
* | ||
* @return int $migrationsColumnLength The migration string column length. | ||
*/ | ||
public function getMigrationsColumnLength() | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Missing type declaration |
||
{ | ||
return $this->migrationsColumnLength; | ||
} | ||
|
||
/** | ||
* Set the new migrations directory where new migration classes are generated | ||
* | ||
|
@@ -751,7 +780,7 @@ public function createMigrationTable() | |
} | ||
|
||
$columns = [ | ||
$this->migrationsColumnName => new Column($this->migrationsColumnName, Type::getType('string'), ['length' => 255]), | ||
$this->migrationsColumnName => new Column($this->migrationsColumnName, Type::getType('string'), ['length' => $this->migrationsColumnLength]), | ||
]; | ||
$table = new Table($this->migrationsTableName, $columns); | ||
$table->setPrimaryKey([$this->migrationsColumnName]); | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing type declaration
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The codebase I'm PR'ing against doesn't have type declarations, so I was trying to stay consistent with that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The codebase has already been changed to require PHP 7.1 😉