Extract parameter formatting from Version class and move to Parameter… #641
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Majkl578
suggested changes
May 6, 2018
| */ | ||
| public function formatParameters(array $params, array $types) : string | ||
| { | ||
| if (empty($params)) { |
There was a problem hiding this comment.
Please avoid empty(), either use count(...) !== 0 or !== []
| $out = []; | ||
| foreach ($params as $key => $value) { | ||
| $type = $types[$key] ?? 'string'; | ||
| $outval = '[' . $this->formatParameter($value, $type) . ']'; |
| private function parameterToString($value) : string | ||
| { | ||
| if (is_array($value)) { | ||
| return implode(', ', array_map([$this, 'parameterToString'], $value)); |
There was a problem hiding this comment.
Better use closure here instead of string name.
| } | ||
|
|
||
| /** | ||
| * @param int[]|bool[]|string[]|array|int|string|bool $value |
There was a problem hiding this comment.
the function is doing recursion 🤔
jwage
force-pushed
the
extract-parameter-formatting
branch
from
17443b9 to
1f4925f
Compare
Majkl578
approved these changes
May 6, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #640