Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix --write-sql option so it can accept a path to write the sql file to. #666

Merged
merged 1 commit into from
May 12, 2018

Conversation

jwage
Copy link
Member

@jwage jwage commented May 11, 2018

Q A
Type feature
BC Break no
Fixed issues #606

Summary

Allows the --write-sql to accept a value to write the sql file to. If you don't specify a value, it writes the file to the current working directory.

@jwage jwage force-pushed the write-sql-path branch from 2920358 to 1e20939 Compare May 11, 2018 21:44
@jwage jwage added this to the 2.0 milestone May 11, 2018
@jwage jwage force-pushed the write-sql-path branch from 1e20939 to 08856ac Compare May 11, 2018 22:10
@jwage jwage self-assigned this May 11, 2018
@jwage jwage requested a review from Majkl578 May 11, 2018 22:27
@jwage jwage force-pushed the write-sql-path branch 2 times, most recently from 873f561 to b4114d6 Compare May 12, 2018 00:43
Copy link
Contributor

@localheinz localheinz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@@ -34,7 +34,8 @@ protected function configure() : void
'write-sql',
null,
InputOption::VALUE_OPTIONAL,
'The path to output the migration SQL file instead of executing it. Default to current working directory.'
'The path to output the migration SQL file instead of executing it. Default to current working directory.',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be Defaults to or Default is instead?

@jwage jwage force-pushed the write-sql-path branch 2 times, most recently from a1c791e to dccd60d Compare May 12, 2018 14:54
@jwage jwage force-pushed the write-sql-path branch from dccd60d to 7aa78aa Compare May 12, 2018 15:08
@jwage jwage merged commit c7d0d57 into master May 12, 2018
@jwage jwage deleted the write-sql-path branch May 12, 2018 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants