Add phpstan-phpunit to composer.json #733
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alcaeus
approved these changes
Jun 13, 2018
|
Does this also need a modification of For reference, see https://github.com/phpstan/phpstan-phpunit#usage: |
|
@localheinz Yes. |
Majkl578
suggested changes
Jun 13, 2018
|
Whoops. Forgot that. It is updated now. |
localheinz
approved these changes
Jun 13, 2018
phpstan.neon
Outdated
| @@ -5,3 +5,4 @@ parameters: | |||
|
|
|||
| includes: | |||
| - vendor/phpstan/phpstan-strict-rules/rules.neon | |||
| - vendor/phpstan/phpstan-phpunit/extension.neon | |||
There was a problem hiding this comment.
Probably not that important, but in case more rules will be imported, I recommend to keep includes sorted, perhaps using the Lines Sorter plugin for PhpStorm.
|
Build failure appears to be unrelated; restarting the build might fix it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add phpstan/phpstan-phpunit to composer.json