Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHPstan 0.10 #739

Merged
merged 3 commits into from
Jun 25, 2018
Merged

PHPstan 0.10 #739

merged 3 commits into from
Jun 25, 2018

Conversation

Majkl578
Copy link
Contributor

Q A
Type improvement
BC Break no

Summary

Update to PHPStan 0.10.

Slightly improved error handling in configuration loaders.

Added phpstan-deprecations-rules.
There are no errors currenty, but with symfony/symfony#27647, it will start reporting:

 ------ ------------------------------------------------------------------------------------ 
  Line   lib/Doctrine/Migrations/Configuration/Connection/Loader/ConnectionHelperLoader.php  
 ------ ------------------------------------------------------------------------------------ 
  30     Instantiation of deprecated class Symfony\Component\Console\Helper\HelperSet.       
 ------ ------------------------------------------------------------------------------------ 

 ------ ---------------------------------------------------------------------------------------------- 
  Line   lib/Doctrine/Migrations/Tools/Console/Command/AbstractCommand.php                             
 ------ ---------------------------------------------------------------------------------------------- 
  115    Call to deprecated method getHelperSet() of class Symfony\Component\Console\Command\Command.  
  144    Call to deprecated method getHelper() of class Symfony\Component\Console\Command\Command.     
  178    Call to deprecated method getHelperSet() of class Symfony\Component\Console\Command\Command.  
  195    Call to deprecated method getHelperSet() of class Symfony\Component\Console\Command\Command.  
 ------ ---------------------------------------------------------------------------------------------- 

 ------ ------------------------------------------------------------------------------------------- 
  Line   lib/Doctrine/Migrations/Tools/Console/Command/DiffCommand.php                              
 ------ ------------------------------------------------------------------------------------------- 
  146    Call to deprecated method getHelper() of class Symfony\Component\Console\Command\Command.  
 ------ ------------------------------------------------------------------------------------------- 

 ------ ------------------------------------------------------------------------------------------ 
  Line   lib/Doctrine/Migrations/Tools/Console/ConsoleRunner.php                                   
 ------ ------------------------------------------------------------------------------------------ 
  43     Call to deprecated method setHelperSet() of class Symfony\Component\Console\Application.  
  64     Call to deprecated method getHelperSet() of class Symfony\Component\Console\Application.  
 ------ ------------------------------------------------------------------------------------------ 

 ------ -------------------------------------------------------------------------------------------------------------------------------------- 
  Line   lib/Doctrine/Migrations/Tools/Console/Helper/ConfigurationHelper.php                                                                  
 ------ -------------------------------------------------------------------------------------------------------------------------------------- 
  23     Class Doctrine\Migrations\Tools\Console\Helper\ConfigurationHelper extends deprecated class Symfony\Component\Console\Helper\Helper.  
 ------ -------------------------------------------------------------------------------------------------------------------------------------- 

                                                                                                                        
 [ERROR] Found 9 errors

@Majkl578 Majkl578 added this to the 2.0.0-alpha2 milestone Jun 25, 2018
@Majkl578 Majkl578 requested a review from jwage June 25, 2018 00:09
@jwage jwage merged commit f392a2b into doctrine:master Jun 25, 2018
@Majkl578 Majkl578 deleted the phpstan-0.10 branch June 25, 2018 14:47
@jwage jwage modified the milestones: 2.0.0-beta1, 2.0.0 Aug 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants