Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: No need to update composer itself twice #740

Merged
merged 1 commit into from
Jun 26, 2018
Merged

Fix: No need to update composer itself twice #740

merged 1 commit into from
Jun 26, 2018

Conversation

localheinz
Copy link
Contributor

Q A
Type bug
BC Break no
Fixed issues n/a

Summary

This PR

  • removes a redundant run of composer self-update on Travis

💁‍♂️ For reference, see

@jwage
Copy link
Member

jwage commented Jun 26, 2018

Where is it calling composer self-update already?

@localheinz
Copy link
Contributor Author

@jwage

See https://travis-ci.org/doctrine/migrations/jobs/396429439#L473-L476, Travis itself ensures that composer is self-updated.

@jwage
Copy link
Member

jwage commented Jun 26, 2018

Ah cool. Thanks for clarifying.

@jwage jwage added this to the 2.0.0-alpha2 milestone Jun 26, 2018
@jwage jwage self-assigned this Jun 26, 2018
@jwage jwage merged commit 196766a into doctrine:master Jun 26, 2018
@localheinz localheinz deleted the fix/self-update branch June 26, 2018 19:43
@localheinz
Copy link
Contributor Author

Thank you, @jwage!

@jwage jwage modified the milestones: 2.0.0-beta1, 2.0.0 Aug 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jwage jwage

Labels
Improvement
Projects
None yet
Milestone
2.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@localheinz @jwage