Update Box to the latest stable release (3.1.0) #757
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Update Box to the latest stable release (3.1.0) - Remove redundant settings - Rename `box.json` to `box.json.dist` and add `box.json` to the ignored files to allow one to tweak the Box settings locally easily - Tweak the Box compilation script to make it more resilient in case of failure
Majkl578
reviewed
Oct 8, 2018
| composer update | ||
|
|
||
| php box.phar compile -vv | ||
|
|
||
| composer config --unset platform | ||
| trap restorePlatform exit |
There was a problem hiding this comment.
This trap should be before running compile, otherwise it has basically no effect here at the end.
| ./download-box.sh | ||
|
|
||
| function restorePlatform { |
There was a problem hiding this comment.
Hmm, this is a rare signature for bash functions IMO.
There was a problem hiding this comment.
Usually bash functions are written as such:
functionName() {
body
}There was a problem hiding this comment.
Ah right, it's been a while since I've done some bash so I just went with whatever though was correct and my IDE didn't complain either... Can be renamed I guess
| # lock PHP to minimum allowed version | ||
| composer config platform.php 7.1.0 | ||
| cp composer.lock composer.lock.back || true |
There was a problem hiding this comment.
Why ".back"? Standard extension for backups is ".bak" or more preferably ".orig".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
box.jsontobox.json.distand addbox.jsonto the ignored files to allow one to tweakthe Box settings locally easily