Skip native lazy object initialization for unmapped properties #2922
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GromNaN
force-pushed
the
skip-unmapped-properties
branch
from
65b9940 to
b4022ab
Compare
jmikola
reviewed
Nov 26, 2025
| { | ||
| if (isset($this->skippedProperties[$metadata->name])) { | ||
| return $this->skippedProperties[$metadata->name]; | ||
| } |
| continue; | ||
| } | ||
|
|
||
| if ($property->isVirtual()) { |
Member
There was a problem hiding this comment.
I'm pleasantly surprised that the ReflectionProperty docs explain what virtual properties are.
| $skippedProperties = []; | ||
| foreach ($metadata->reflClass->getProperties() as $property) { | ||
| if (array_key_exists($property->name, $metadata->propertyAccessors)) { | ||
| continue; |
Member
There was a problem hiding this comment.
Just to confirm, every mapped field should have its own property accessor according to ClassMetadata::mapField(), correct?
So this foreach look is really just checking for unmapped, non-virtual properties.
Will this logic be useful in any other contexts? If so, it may be worth capturing this logic in a ClassMetadata method.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Re-implement #2698 for native lazy objects.
Using the method
ReflectionProperty::skipLazyInitialization, accessing properties that are not mapped in Doctrine will not initialize the document object.