Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sidebar Menu is updated in rapidly after hot reload #1299

Closed
theparthy opened this issue Dec 3, 2019 · 3 comments
Closed

Sidebar Menu is updated in rapidly after hot reload #1299

theparthy opened this issue Dec 3, 2019 · 3 comments

Comments

@theparthy
Copy link

Bug Report

Describe the bug
The Sidebar is updated rapidly, after hot reload.
When left alone for a while, the browser tab gets slugish.
The links are not Clickable.
After a full reload everything is fine.

To Reproduce

Repo

  1. git clone git@github.com:theparthy/docz-sidebar-issue.git
  2. Run npm run docz dev
  3. got to src/elements/Spinner/index.mdx
  4. remove or add Component in Playground
  5. After hot reload look at sidebar in Elements tab in DevTools. (Screenshot Below)

Expected behavior
Only one update of Sidebar

Environment

  • docz version: [2.1.1]
  • OS: [OSX 10.14.6]
  • Node/npm version: [v12.3.1]
  • Other libraries used
    "reakit": "^1.0.0-beta.13",
    "styled-components": "^4.4.1",
    "styled-icons": "^9.0.1",
    "styled-is": "^1.3.0",
    "styled-system": "^5.1.4"

Additional context/Screenshots

image

@rakannimer
Copy link
Contributor

Hey @theparthy

Thanks for catching and reporting that bug, it's an annoying one !

The fix will be released with 2.2.0.

Meanwhile you can use 2.2.0-alpha.7 (yarn add docz@next) to use the patched code right away 👍

@theparthy
Copy link
Author

Hey @rakannimer

thanks for the quick response and fix.
2.2.0-alpha.7 fixes the issue.

@rakannimer
Copy link
Contributor

Awesome ! You're welcome !

Going to close this, feel free to re-open or comment here if it re-occurs 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants