Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(docz-core): remove https option and fix message #321

Merged
merged 1 commit into from
Sep 10, 2018
Merged

fix(docz-core): remove https option and fix message #321

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/docz-core/src/bundlers/webpack/config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ const uglify = new UglifyJs({
export const createConfig = (args: Args, env: Env) => async (
babelrc: BabelRC
): Promise<Configuration> => {
const { debug, host, port, protocol } = args
const { debug, host, port } = args

const config = new Config()
const isProd = env === 'production'
Expand Down Expand Up @@ -227,7 +227,7 @@ export const createConfig = (args: Args, env: Env) => async (
{
compilationSuccessInfo: {
messages: [
`Your application is running at ${protocol}://${hostname}:${port}`,
`Your application is running at http://${hostname}:${port}`,
],
},
},
Expand Down
5 changes: 0 additions & 5 deletions packages/docz-core/src/commands/args.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,6 @@ export interface Argv {
debug: boolean
typescript: boolean
propsParser: boolean
protocol: string
host: string
port: number
websocketPort: number
Expand Down Expand Up @@ -148,10 +147,6 @@ export const args = (env: Env) => (yargs: any) => {
type: 'boolean',
default: getEnv('docz.debug', false),
})
yargs.positional('protocol', {
type: 'string',
default: getEnv('docz.https', true) ? 'https' : 'http',
})
yargs.positional('host', {
type: 'string',
default: getEnv('docz.host', '127.0.0.1'),
Expand Down