Merge pull request #4848 from dodona-edu/revert-4617-fix/series-witho…

…ut-courseid Prevent crash on series creation without course
dodona-edu · Aug 1, 2023 · cd26776 · cd26776
2 parents df940af + 42699af
commit cd26776
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 7 deletions.
diff --git a/app/controllers/series_controller.rb b/app/controllers/series_controller.rb
@@ -108,13 +108,9 @@ def edit
   # POST /series.json
   def create
     @series = Series.new(permitted_attributes(Series))
-    if @series.course.present?
-      authorize @series.course, :add_series?
-    else
-      @series.errors.add(:course_id, I18n.t('errors.messages.blank'))
-    end
+    authorize @series
     respond_to do |format|
-      if @series.course.present? && @series.save
+      if @series.save
         format.html { redirect_to edit_series_path(@series), notice: I18n.t('controllers.created', model: Series.model_name.human) }
         format.json { render :show, status: :created, location: @series }
       else

diff --git a/test/controllers/series_controller_test.rb b/test/controllers/series_controller_test.rb
@@ -63,7 +63,6 @@ class SeriesControllerTest < ActionDispatch::IntegrationTest
   test 'create series with missing course_id should 422' do
     post series_index_url, params: { series: { name: 'Test series' }, format: :json }
     assert_response :unprocessable_entity
-    assert_includes assigns(:series).errors.messages[:course_id], I18n.t('errors.messages.blank')
   end
 
   test 'update series should redirect to course' do