Merge pull request #5995 from dodona-edu/chore/improve-sign-in-logging

Also log user when legacy sign in methods are used
dodona-edu · Dec 10, 2024 · d28dffe · d28dffe
2 parents 4c2d612 + 80a20c0
commit d28dffe
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/app/controllers/auth/omniauth_callbacks_controller.rb b/app/controllers/auth/omniauth_callbacks_controller.rb
@@ -235,7 +235,7 @@ def find_identity_by_uid
       identity = Identity.joins(:user).find_by(user: { first_name: auth_hash.info.first_name, last_name: auth_hash.info.last_name }, provider: provider, identifier_based_on_email: true) if identity.nil?
       return nil if identity.nil?
 
-      Event.new(event_type: :other, message: 'Office365 user signed in with legacy identifier').save!
+      Event.new(event_type: :other, message: 'Office365 user signed in with legacy identifier', user: identity.user).save!
 
       # Update the identifier to the new uid
       identity.update(identifier: auth_uid, identifier_based_on_email: false)
@@ -251,7 +251,7 @@ def find_identity_by_uid
       identity = Identity.joins(:user).find_by(user: { first_name: auth_hash.info.first_name, last_name: auth_hash.info.last_name }, provider: provider, identifier_based_on_username: true) if identity.nil?
       return nil if identity.nil?
 
-      Event.new(event_type: :other, message: 'Smartschool user signed in with legacy identifier').save!
+      Event.new(event_type: :other, message: 'Smartschool user signed in with legacy identifier', user: identity.user).save!
 
       # Update the identifier to the new uid
       identity.update(identifier: auth_uid, identifier_based_on_username: false)