bring test coverage to 100%

[rien]

I like the idea of this blogpost.
TL;DR: a project should have a test coverage of 100%. Not all lines should be tested, but lines we don't want to write a test for should be explicitly marked as such. We can ignore lines like this:

# :nocov:
def skip_this_method
  never_reached
end
# :nocov:

I went trough our coverage report and we are currently just below 80%. There are some lines that we really want to cover (institutions_controller.rb is currently completely uncovered) but some are simply impossible to cover (lib/SAML/my_resource_validator.rb for example).

I suggest someone goes trough this report (found in coverage/index.htm after running rails test) and for each block of uncovered code:

• either writes a test covering that block
• either surrounds that block with # :nocov: <Reason why this block is skipped>

Finally, by using SimpleCov.minimum_coverage 100 we can enforce that this being done for each line of extra code that is added to our project.

@bmesuere, @charvp what are your opinions? I think this would be an ideal issue for a job student.

[chvp]

Coverage reports are broken right now until simplecov-ruby/simplecov#718 is fixed.

[rien]

Ah, I have a temporary fix on feature/description-iframe: 2cebcbc which can be used.

Should I make a separate PR with this fix?

[chvp]

You can already set PARALLEL_WORKERS=1 if you really want serial test execution.

[bmesuere]

+1 for this idea, but we must make sure that they are meaningful tests and not something to reach 100% coverage and be done with it

[rien]

You can already set PARALLEL_WORKERS=1 if you really want serial test execution.

Oh, nice. I'll remove that commit then.