Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow multi-line annotations #2826

Closed
Tracked by #4361
chvp opened this issue Jun 5, 2021 · 3 comments
Closed
Tracked by #4361

Allow multi-line annotations #2826

chvp opened this issue Jun 5, 2021 · 3 comments
Assignees
Labels
feature New feature or request low priority Thing we want to see implemented at some point

Comments

@chvp
Copy link
Member

chvp commented Jun 5, 2021

Allow to add comments/questions on a continuous selection of multiple lines.

From #1852 (comment)

@chvp chvp added the feature New feature or request label Jun 5, 2021
@bmesuere bmesuere added this to Roadmap Apr 17, 2022
@bmesuere bmesuere moved this to Unplanned in Roadmap Apr 17, 2022
@bmesuere
Copy link
Member

bmesuere commented Feb 5, 2023

Github behaviour:

  • if you hover over a line, a plus button appears in the left margin
  • if you hover over the button, the button grows in size
  • if you click the button, the comment form appears
  • if you drag the button, the button stays in place but a thick line in the color of the button appears in the margin
    • you can only drag down, not up
  • if you release the drag, the comment form appears. The button and line disappear, but the selected lines are highlighted in yellow. Above the text area, a small help text "Commenting on lines xx to xx" is shown. For single line comments, the highlight and info text is not present.
  • when rendering a multi-line comment in the code view, GitHub does not show which lines the comment belongs to. It is rendered under the last line of the selection as a normal comment. In the PR-comment view where just the comments are rendered the additional lines are included in the small code snippet that shows context.

@bmesuere bmesuere added the low priority Thing we want to see implemented at some point label Feb 5, 2023
@pdawyndt
Copy link
Contributor

pdawyndt commented Feb 5, 2023

Maybe related:

  • comments could be moved to another location by updating the numbers in a help text like "Commenting on lines xx to xx" (both for single line and multiline)
  • I often repeat the same comment within the same submission: copy followed by move might speed up this process

@bmesuere bmesuere moved this from Unplanned to Todo in Roadmap Feb 11, 2023
@jorg-vr jorg-vr self-assigned this Apr 12, 2023
@jorg-vr jorg-vr moved this from Todo to In Progress in Roadmap Apr 12, 2023
@jorg-vr
Copy link
Contributor

jorg-vr commented May 24, 2023

completed by #4596

@jorg-vr jorg-vr closed this as completed May 24, 2023
@github-project-automation github-project-automation bot moved this from In Progress to Done in Roadmap May 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request low priority Thing we want to see implemented at some point
Projects
Status: Done
Development

No branches or pull requests

4 participants