Show number of unanswered questions in title of question page #2302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niknetniko
force-pushed
the
feature/question-title
branch
from
30d6a08 to
c1c8c46
Compare
niknetniko
force-pushed
the
feature/question-title
branch
from
c1c8c46 to
3a5e259
Compare
chvp
approved these changes
Oct 2, 2020
bmesuere
approved these changes
Oct 5, 2020
|
Visual clue (red dot in favicon) upon unanswered questions is only visible while on question dashboard
not while on any other course-level page (where red dot is visible in navigation bar but not in favicon).
Has this been done on purpose, or is this something that was overlooked? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds the number of unanswered questions in the title & shows a dot in the favicon if there are any unanswered questions (exactly like the notification dot).
The dot in the favicon now serves two purposes, but since course administrators currently don't receive a lot of notifications (I assume), I don't think it's a big problem.
More technically, the PR adds a
FaviconManager, which tracks why a dot is shown in the favicon. For example, if you have unread notifications but you resolve all questions, we can't hide the dot yet (and vice versa).Screenshot:
Closes #2275.