Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update privacy declaration to also cover personal accounts #3855

Merged
merged 15 commits into from
Aug 17, 2022
Merged

Update privacy declaration to also cover personal accounts #3855

merged 15 commits into from
Aug 17, 2022

Conversation

jorg-vr
Copy link
Contributor

@jorg-vr jorg-vr commented Aug 2, 2022

This pull request updates the privacy page and the data page to also cover personal accounts.

Part of #2597.

@jorg-vr jorg-vr added the feature New feature or request label Aug 2, 2022
@jorg-vr jorg-vr self-assigned this Aug 2, 2022
@jorg-vr jorg-vr mentioned this pull request Aug 2, 2022
Closed
2 tasks
@jorg-vr jorg-vr changed the base branch from develop to feature/personal-accounts August 3, 2022 13:38
@jorg-vr jorg-vr marked this pull request as ready for review August 3, 2022 14:28
@jorg-vr jorg-vr requested a review from a team as a code owner August 3, 2022 14:28
@jorg-vr jorg-vr requested review from bmesuere and niknetniko and removed request for a team August 3, 2022 14:28
niknetniko
niknetniko requested changes Aug 5, 2022
View reviewed changes
app/views/pages/data.en.html.erb Outdated Show resolved Hide resolved
app/views/pages/data.nl.html.erb Outdated Show resolved Hide resolved
app/views/pages/privacy.nl.html.erb Outdated Show resolved Hide resolved
@jorg-vr @niknetniko
Apply suggestions from code review
f3016a1 
Co-authored-by: Niko Strijbol <strijbol.niko@gmail.com>
@jorg-vr jorg-vr requested a review from niknetniko August 5, 2022 10:03
@bmesuere bmesuere requested a review from chvp August 16, 2022 08:21
bmesuere
bmesuere requested changes Aug 16, 2022
View reviewed changes
app/views/pages/data.nl.html.erb Outdated Show resolved Hide resolved
app/views/pages/privacy.en.html.erb Outdated Show resolved Hide resolved
app/views/pages/privacy.en.html.erb Outdated Show resolved Hide resolved
app/views/pages/privacy.en.html.erb Outdated Show resolved Hide resolved
@bmesuere bmesuere mentioned this pull request Aug 16, 2022
Merged
1 task
chvp
chvp reviewed Aug 16, 2022
View reviewed changes
Copy link
Member

@chvp chvp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good, but as discussed in the break the split between institutional use and personal use needs to be clearer. (Reviewing so that it's not in my to-review list.)

@jorg-vr jorg-vr requested review from bmesuere and chvp August 16, 2022 14:59
chvp
chvp approved these changes Aug 16, 2022
View reviewed changes
app/views/pages/privacy.en.html.erb Outdated Show resolved Hide resolved
app/views/pages/privacy.nl.html.erb Outdated Show resolved Hide resolved
jorg-vr and others added 2 commits August 17, 2022 15:05
@jorg-vr @chvp
Update app/views/pages/privacy.en.html.erb
e32c603 
Co-authored-by: Charlotte Van Petegem <charlotte.vanpetegem@ugent.be>
@jorg-vr @chvp
Update app/views/pages/privacy.nl.html.erb
514424c 
Co-authored-by: Charlotte Van Petegem <charlotte.vanpetegem@ugent.be>
@jorg-vr jorg-vr merged commit 3f122d0 into feature/personal-accounts Aug 17, 2022
@jorg-vr jorg-vr deleted the feature/update-privacy-policy branch August 17, 2022 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chvp chvp chvp approved these changes

@niknetniko niknetniko niknetniko approved these changes

@bmesuere bmesuere bmesuere approved these changes

Assignees

@jorg-vr jorg-vr

Labels
feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jorg-vr @bmesuere @niknetniko @chvp