Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Force new private users to accept the privacy policy before creating an account #3859

Merged
merged 15 commits into from
Aug 18, 2022
Merged

Force new private users to accept the privacy policy before creating an account #3859

merged 15 commits into from
Aug 18, 2022

Conversation

jorg-vr
Copy link
Contributor

@jorg-vr jorg-vr commented Aug 4, 2022 •
edited
Loading

This pull request forces new private users to accept the privacy policy before creating an account. Replaces #3803
Institutional users can still sign up without prompt.

image
image

  • Tests were added

Part of #2597 .

@jorg-vr jorg-vr added the feature New feature or request label Aug 4, 2022
@jorg-vr jorg-vr self-assigned this Aug 4, 2022
@jorg-vr jorg-vr temporarily deployed to naos August 4, 2022 08:18 Inactive
@jorg-vr jorg-vr temporarily deployed to naos August 4, 2022 09:00 Inactive
@jorg-vr jorg-vr temporarily deployed to naos August 4, 2022 09:38 Inactive
@jorg-vr jorg-vr temporarily deployed to naos August 4, 2022 11:26 Inactive
@jorg-vr jorg-vr temporarily deployed to naos August 4, 2022 12:04 Inactive
@jorg-vr jorg-vr marked this pull request as ready for review August 4, 2022 12:09
@jorg-vr jorg-vr requested a review from a team as a code owner August 4, 2022 12:09
@jorg-vr jorg-vr requested review from bmesuere and niknetniko and removed request for a team August 4, 2022 12:09
niknetniko
niknetniko requested changes Aug 5, 2022
View reviewed changes
config/locales/views/auth/nl.yml Outdated Show resolved Hide resolved
config/locales/views/auth/nl.yml Outdated Show resolved Hide resolved
@jorg-vr @niknetniko
Apply suggestions from code review
ed4297b 
Co-authored-by: Niko Strijbol <strijbol.niko@gmail.com>
@jorg-vr jorg-vr requested a review from niknetniko August 5, 2022 12:28
@bmesuere bmesuere mentioned this pull request Aug 16, 2022
Merged
1 task
@bmesuere bmesuere requested a review from chvp August 16, 2022 08:38
@jorg-vr jorg-vr mentioned this pull request Aug 16, 2022
Merged
chvp
chvp reviewed Aug 16, 2022
View reviewed changes
Copy link
Member

@chvp chvp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but if I understood correctly this will be changed to not force an accept for institutional users?

@jorg-vr jorg-vr marked this pull request as draft August 16, 2022 13:06
@jorg-vr
Copy link
Contributor Author

jorg-vr commented Aug 16, 2022

@chvp yes I will update this, so that the new behavior only applies for personal accounts

@jorg-vr jorg-vr mentioned this pull request Aug 16, 2022
Closed
2 tasks
@jorg-vr jorg-vr changed the base branch from feature/personal-accounts to feature/allow-personal-users August 16, 2022 13:35
@jorg-vr jorg-vr changed the title Force new users to accept the privacy policy before creating an account Force new private users to accept the privacy policy before creating an account Aug 16, 2022
@jorg-vr jorg-vr temporarily deployed to naos August 16, 2022 13:45 Inactive
@jorg-vr jorg-vr temporarily deployed to naos August 16, 2022 13:55 Inactive
@jorg-vr jorg-vr marked this pull request as ready for review August 16, 2022 14:02
@jorg-vr jorg-vr requested a review from chvp August 16, 2022 14:02
Base automatically changed from feature/allow-personal-users to feature/personal-accounts August 18, 2022 08:57
@jorg-vr jorg-vr merged commit b2faeb0 into feature/personal-accounts Aug 18, 2022
@jorg-vr jorg-vr deleted the feature/force-privacy-policy branch August 18, 2022 08:58
@jorg-vr jorg-vr mentioned this pull request Feb 27, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chvp chvp chvp approved these changes

@niknetniko niknetniko niknetniko approved these changes

@bmesuere bmesuere bmesuere approved these changes

Assignees

@jorg-vr jorg-vr

Labels
feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jorg-vr @bmesuere @niknetniko @chvp