Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove tokenfield typeahead #4189

Merged
merged 4 commits into from
Nov 24, 2022
Merged

Remove tokenfield typeahead #4189

merged 4 commits into from
Nov 24, 2022

Conversation

jorg-vr
Copy link
Contributor

@jorg-vr jorg-vr commented Nov 24, 2022

This pull request removes tokenfield/typeahead.

All uses had already been removed by #4023, #4083 and #3498

I also removed all mentions of the vendor folder, as this was the last module using that system.

I moved the css we still use for tokens to components/tokens.css.scss in order to get rid of mentions of the old tokenfield component.

Part of #3590

@jorg-vr jorg-vr added the chore Repository/build/dependency maintenance label Nov 24, 2022
@jorg-vr jorg-vr self-assigned this Nov 24, 2022
@jorg-vr jorg-vr mentioned this pull request Nov 24, 2022
9 tasks
@jorg-vr jorg-vr marked this pull request as ready for review November 24, 2022 09:22
@jorg-vr jorg-vr requested a review from a team as a code owner November 24, 2022 09:22
@jorg-vr jorg-vr requested review from niknetniko and chvp and removed request for a team November 24, 2022 09:22
@chvp chvp added the deploy mestra Request a deployment on mestra label Nov 24, 2022
@chvp chvp temporarily deployed to mestra November 24, 2022 09:32 Inactive
@github-actions github-actions bot removed the deploy mestra Request a deployment on mestra label Nov 24, 2022
Copy link
Member

@chvp chvp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the DB changes: it's probably the easiest to do a db reset; this should re-initialize your db using the schema.rb.

@jorg-vr jorg-vr temporarily deployed to naos November 24, 2022 13:37 Inactive
@jorg-vr jorg-vr merged commit f359383 into develop Nov 24, 2022
@jorg-vr jorg-vr deleted the chore/remove-tokenfield branch November 24, 2022 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Repository/build/dependency maintenance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants