Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only show course from latest year on home page #4245

Merged
merged 11 commits into from
Dec 19, 2022

Conversation

jorg-vr
Copy link
Contributor

@jorg-vr jorg-vr commented Dec 14, 2022

This pull request removes old course cards from the home page, only showing the latest year. Using a dropdown it allows to cycle through previous years.

Favorited courses are always shown on top.
image

image

No dropdown is shown when there are less then two different years
image

Part of #2882

@jorg-vr jorg-vr added the feature New feature or request label Dec 14, 2022
@jorg-vr jorg-vr self-assigned this Dec 14, 2022
@jorg-vr jorg-vr marked this pull request as ready for review December 15, 2022 09:02
@jorg-vr jorg-vr requested a review from a team as a code owner December 15, 2022 09:02
@jorg-vr jorg-vr requested review from bmesuere and chvp and removed request for a team December 15, 2022 09:02
@bmesuere bmesuere added the deploy mestra Request a deployment on mestra label Dec 15, 2022
@bmesuere bmesuere temporarily deployed to mestra December 15, 2022 12:20 — with GitHub Actions Inactive
@github-actions github-actions bot removed the deploy mestra Request a deployment on mestra label Dec 15, 2022
Copy link
Member

@bmesuere bmesuere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good, but I'm not sure about the current favorite behaviour. Shouldn't we add a separate "year" for favorites?
Two smaller things:

  • Can you make the dropdown right-aligned (do the dropdown aligns with the right of the button?) Should be possible with <div class="dropdown-menu dropdown-menu-right">
  • Can you style the years with an n-dash (?) as is done on the course cards?

@bmesuere
Copy link
Member

bmesuere commented Dec 15, 2022

👍 Looks good, but I'm not sure about the current favorite behaviour. Shouldn't we add a separate "year" for favorites?

  • As an alternative, keep the current behaviour, but place the favorite courses in a separate "favorite courses" section above "courses".

@jorg-vr jorg-vr requested a review from bmesuere December 15, 2022 14:29
@bmesuere bmesuere added the deploy mestra Request a deployment on mestra label Dec 15, 2022
@bmesuere bmesuere temporarily deployed to mestra December 15, 2022 14:31 — with GitHub Actions Inactive
@github-actions github-actions bot removed the deploy mestra Request a deployment on mestra label Dec 15, 2022
@jorg-vr jorg-vr merged commit 5883345 into develop Dec 19, 2022
@jorg-vr jorg-vr deleted the feature/home-current-year branch December 19, 2022 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants