series.js: remove jquery and convert to typescript #4266
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request removes all jquery from series.js and converts it to typescript. It also fixes some small bugs.
Fix 1: a small bug for the css on activities: before, when adding
pending
andnew
to an activity tr-element, this didn't have any effect on the css. Now when addingpending
ornew
, the opacity is correctly changed (in the short time frames it takes to add an activity to a series):Before (when
pending
):After (when
pending
):Fix 2: I also made sure that a user can't add/remove the same activity multiple times. This was possible when it was taking a longer time for adding/removing an activity (e.g. waiting on a response), so these changes are only visible for this edge case. For adding, the add button was not hidden when a series is being added (in the
new
andpending
stages). The add button only became hidden when the series was successfully added. This made it possible to add multiple instances of the same activity. The new flow isaddingActivityFailed
removingActivityFailed
.Before (when
pending
):After (when
pending
):This is progress on #3590