Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

repository.js: remove jquery and convert to typescript #4298

Merged
merged 3 commits into from
Jan 10, 2023

Conversation

freyavs
Copy link
Contributor

@freyavs freyavs commented Jan 4, 2023

This pull request removes jquery from repository.js and converts it to typescript. There's also been a small change in the way buttons are shown (they get hidden in stead of removed).

It also adds a small style fix: When the add button was removed, the row changed in height. Now heights stay the same

Before:
2023-01-06_13-37

After:
2023-01-06_13-37_1

@freyavs freyavs added the chore Repository/build/dependency maintenance label Jan 4, 2023
@freyavs freyavs self-assigned this Jan 4, 2023
@freyavs freyavs mentioned this pull request Jan 6, 2023
9 tasks
@freyavs freyavs marked this pull request as ready for review January 6, 2023 13:09
@freyavs freyavs requested a review from a team as a code owner January 6, 2023 13:09
@freyavs freyavs requested review from niknetniko and jorg-vr and removed request for a team January 6, 2023 13:09
Copy link
Contributor

@jorg-vr jorg-vr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, left some minor comments.

Thanks for fixing the small bugs as well!

app/controllers/repositories_controller.rb Outdated Show resolved Hide resolved
app/assets/javascripts/repository.ts Outdated Show resolved Hide resolved
@jorg-vr jorg-vr merged commit 6dcfe87 into develop Jan 10, 2023
@jorg-vr jorg-vr deleted the chore/repository-jquery-removal branch January 10, 2023 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Repository/build/dependency maintenance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants