Add unique index to series_id for evaluations #4359
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorg-vr
requested review from
niknetniko and
chvp
and removed request for
a team
chvp
approved these changes
Jan 30, 2023
niknetniko
approved these changes
Jan 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds a unique index to evaluations. This avoids multiple evaluations belonging to the same series.
Although a new evaluation should never be created if one already exists, it has happened in practice, resulting in further errors down the line. The unique index should result in an error upon creation, which we can then look into avoiding.
Tested on naos. Duplicate evaluations are removed, series can be deleted again.
Closes #4356 .