Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only show own repositories on the index page for teachers #4380

Merged
merged 6 commits into from
Feb 3, 2023

Conversation

jorg-vr
Copy link
Contributor

@jorg-vr jorg-vr commented Feb 3, 2023

This pull request limits the repository index page to own repositories for non zeus users.

It is only limited on the index page, and not in the policy, as teachers are allowed to see the list of all repositories on other pages. (Eg as filter dropdown to search for exercises)

I also added an empty state to the repository page as this is now relevant.
image

part of #4362

@jorg-vr jorg-vr added the enhancement A change that isn't substantial enough to be called a feature label Feb 3, 2023
@jorg-vr jorg-vr self-assigned this Feb 3, 2023
@jorg-vr jorg-vr marked this pull request as ready for review February 3, 2023 09:05
@jorg-vr jorg-vr requested a review from a team as a code owner February 3, 2023 09:05
@jorg-vr jorg-vr requested review from bmesuere and niknetniko and removed request for a team February 3, 2023 09:05
Copy link
Member

@bmesuere bmesuere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I slightly prefer having a _html empty message with a <br> instead of the current solution with a \n and changing the css behaviour.

Also, I think technically oefeningenrepository's should be one word. Because you're allowed to add a dash to improve readability, I would make it oefeningen-repository's. But I'll let @niknetniko decide.

@jorg-vr
Copy link
Contributor Author

jorg-vr commented Feb 3, 2023

Ik heb de \n vervangen door _html en <br\>. Maar de white-space css aanpassen blijft nodig voor alle text proper te tonen op kleine schermen.
image

config/locales/views/repositories/en.yml Outdated Show resolved Hide resolved
config/locales/views/repositories/en.yml Outdated Show resolved Hide resolved
config/locales/views/repositories/nl.yml Outdated Show resolved Hide resolved
config/locales/views/repositories/nl.yml Show resolved Hide resolved
config/locales/views/repositories/nl.yml Outdated Show resolved Hide resolved
@jorg-vr jorg-vr requested a review from niknetniko February 3, 2023 12:47
@jorg-vr jorg-vr merged commit 11142bd into develop Feb 3, 2023
@jorg-vr jorg-vr deleted the fix/restrict-repository-view branch February 3, 2023 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement A change that isn't substantial enough to be called a feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants