-
-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix multiple repository related paper cuts #4383
Conversation
Co-authored-by: Niko Strijbol <strijbol.niko@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't like the email solution either. Can't we just send an email to the address associated with the repo admin in this case? Since the repo has just been added by that user, using that address seems like a good fallback.
the repo admin is only added after the repo is saved. This was my first solution which I reverted because of a failing test. Do you want to continue with this approach? (In which case I would just remove the test because we know it will fail) |
In that case, maybe add dodona@ugent.be as ultimate fallback? |
Co-authored-by: Bart Mesuere <Bart.Mesuere@UGent.be>
This pull request fixes multiple paper cuts related to repositories.
The placeholder for the clone url on the repositories/new page mentions github.ugent.be. While correct, github.com would be more logical. From Paper cuts #4240
When adding a repo, add a better error message when permissions are missing. From Paper cuts #4240
New message:
The learning activities table (at least the one on the repo page) has no empty state. From Paper cuts #4240
New empty state:
When adding a repository, the existing exercises were not added automatically. From Paper cuts #4240
This issue was only present in staging and production, where the git worker queue allowed the tasks to be done simultaneously/out of order. This should now be forced to consecutive execution.
Part of #4362 .