Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Valentine status overlay #4400

Merged
merged 5 commits into from
Feb 9, 2023
Merged

Valentine status overlay #4400

merged 5 commits into from
Feb 9, 2023

Conversation

tibvdm
Copy link
Collaborator

@tibvdm tibvdm commented Feb 7, 2023 •
edited
Loading

Add a heart overlay for valentine (14/02).

I also added a group to the status icon. This has two main advantages:

  • The size of the heart can be the same size as the circles. Otherwise the circle is visible around the edges.
  • The overlay can control it's base using pure css.

Light mode:
Screenshot 2023-02-08 at 21 02 49

Dark mode:
Screenshot 2023-02-08 at 21 03 47

Homepage:
Screenshot 2023-02-08 at 21 17 04

@tibvdm tibvdm requested a review from a team as a code owner February 7, 2023 22:20
@tibvdm tibvdm requested review from jorg-vr and chvp and removed request for a team February 7, 2023 22:20
jorg-vr
jorg-vr approved these changes Feb 8, 2023
View reviewed changes
Copy link
Contributor

@jorg-vr jorg-vr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please provide a screenshot of darkmode and the home page in the description

@tibvdm
Copy link
Collaborator Author

tibvdm commented Feb 8, 2023

I added a group to the status icon. This has two main advantages:

  • The size of the heart can be the same size as the circles. Otherwise the circle is visible around the edges.
  • The overlay can control it's base using pure css.

Light mode:
Screenshot 2023-02-08 at 21 02 49

Dark mode:
Screenshot 2023-02-08 at 21 03 47

chvp
chvp approved these changes Feb 9, 2023
View reviewed changes
Copy link
Member

@chvp chvp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No additional remarks.

@jorg-vr jorg-vr merged commit 7c39fdc into develop Feb 9, 2023
@jorg-vr jorg-vr deleted the valentine-overlay branch February 9, 2023 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jorg-vr jorg-vr jorg-vr approved these changes

@chvp chvp chvp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tibvdm @jorg-vr @chvp